2018-04-24 19:57:27

by Mathieu Malaterre

Subject: [PATCH] drm/radeon: Change the default to PCI on PowerPC

AGP mode is unstable on PowerPC. Symptoms are generally of the form:

[ 1228.795711] radeon 0000:00:10.0: ring 0 stalled for more than 10240msec

Reviewed-by: Christian König <[email protected]>
Signed-off-by: Mathieu Malaterre <[email protected]>
---
drivers/gpu/drm/radeon/radeon_drv.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index b28288a781ef..2a7977a23b31 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -168,7 +168,12 @@ int radeon_no_wb;
int radeon_modeset = -1;
int radeon_dynclks = -1;
int radeon_r4xx_atom = 0;
+#ifdef __powerpc__
+/* Default to PCI on PowerPC (fdo #95017) */
+int radeon_agpmode = -1;
+#else
int radeon_agpmode = 0;
+#endif
int radeon_vram_limit = 0;
int radeon_gart_size = -1; /* auto */
int radeon_benchmarking = 0;
--
2.11.0

2018-04-24 19:58:30

by Mathieu Malaterre

Subject: Re: [PATCH] drm/radeon: Change the default to PCI on PowerPC

For reference:

https://lists.freedesktop.org/archives/mesa-dev/2016-May/115453.html

2018-04-24 21:55 GMT+02:00 Mathieu Malaterre <[email protected]>:
> AGP mode is unstable on PowerPC. Symptoms are generally of the form:
>
> [ 1228.795711] radeon 0000:00:10.0: ring 0 stalled for more than 10240msec
>
> Reviewed-by: Christian König <[email protected]>
> Signed-off-by: Mathieu Malaterre <[email protected]>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index b28288a781ef..2a7977a23b31 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -168,7 +168,12 @@ int radeon_no_wb;
> int radeon_modeset = -1;
> int radeon_dynclks = -1;
> int radeon_r4xx_atom = 0;
> +#ifdef __powerpc__
> +/* Default to PCI on PowerPC (fdo #95017) */
> +int radeon_agpmode = -1;
> +#else
> int radeon_agpmode = 0;
> +#endif
> int radeon_vram_limit = 0;
> int radeon_gart_size = -1; /* auto */
> int radeon_benchmarking = 0;
> --
> 2.11.0
>

2018-04-25 09:51:16

by Michel Dänzer

Subject: Re: [PATCH] drm/radeon: Change the default to PCI on PowerPC

On 2018-04-24 09:55 PM, Mathieu Malaterre wrote:
> AGP mode is unstable on PowerPC. Symptoms are generally of the form:
>
> [ 1228.795711] radeon 0000:00:10.0: ring 0 stalled for more than 10240msec
>
> Reviewed-by: Christian König <[email protected]>
> Signed-off-by: Mathieu Malaterre <[email protected]>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index b28288a781ef..2a7977a23b31 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -168,7 +168,12 @@ int radeon_no_wb;
> int radeon_modeset = -1;
> int radeon_dynclks = -1;
> int radeon_r4xx_atom = 0;
> +#ifdef __powerpc__
> +/* Default to PCI on PowerPC (fdo #95017) */
> +int radeon_agpmode = -1;
> +#else
> int radeon_agpmode = 0;
> +#endif
> int radeon_vram_limit = 0;
> int radeon_gart_size = -1; /* auto */
> int radeon_benchmarking = 0;
>

Pushed to amd-staging-drm-next, thanks!


--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer