2018-04-26 16:57:30

by Kieran Bingham

Subject: [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder

The DU entity node has been previously added but only as a placeholder.
Populate the node with the properties to use the device.

Signed-off-by: Kieran Bingham <[email protected]>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index e92e6b03333a..8a40bba53027 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1106,9 +1106,21 @@
};

du: display@feb00000 {
+ compatible = "renesas,du-r8a77965";
reg = <0 0xfeb00000 0 0x80000>,
<0 0xfeb90000 0 0x14>;
- /* placeholder */
+ reg-names = "du", "lvds.0";
+ interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 724>,
+ <&cpg CPG_MOD 723>,
+ <&cpg CPG_MOD 721>,
+ <&cpg CPG_MOD 727>;
+ clock-names = "du.0", "du.1", "du.3", "lvds.0";
+ status = "disabled";
+
+ vsps = <&vspd0 0 &vspd1 0 &vspd0 1>;

ports {
#address-cells = <1>;
--
2.17.0

2018-04-26 21:16:40

by Laurent Pinchart

Subject: Re: [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder

Hi Kieran,

Thank you for the patch.

On Thursday, 26 April 2018 19:53:41 EEST Kieran Bingham wrote:
> The DU entity node has been previously added but only as a placeholder.
> Populate the node with the properties to use the device.
>
> Signed-off-by: Kieran Bingham <[email protected]>
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
> e92e6b03333a..8a40bba53027 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1106,9 +1106,21 @@
> };
>
> du: display@feb00000 {
> + compatible = "renesas,du-r8a77965";
> reg = <0 0xfeb00000 0 0x80000>,
> <0 0xfeb90000 0 0x14>;
> - /* placeholder */
> + reg-names = "du", "lvds.0";

The LVDS encoder has been split to a separate node in current bindings. You
can remove the reg-names property and the second reg entry.

> + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 724>,
> + <&cpg CPG_MOD 723>,
> + <&cpg CPG_MOD 721>,
> + <&cpg CPG_MOD 727>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0";

And you can remove the LVDS clock as well (from both clocks and clock-names).

With this fixed,

Reviewed-by: Laurent Pinchart <[email protected]>

> + status = "disabled";
> +
> + vsps = <&vspd0 0 &vspd1 0 &vspd0 1>;
>
> ports {
> #address-cells = <1>;

--
Regards,

Laurent Pinchart

2018-04-27 16:36:20

by Kieran Bingham

Subject: Re: [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder

On 26/04/18 22:15, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thursday, 26 April 2018 19:53:41 EEST Kieran Bingham wrote:
>> The DU entity node has been previously added but only as a placeholder.
>> Populate the node with the properties to use the device.
>>
>> Signed-off-by: Kieran Bingham <[email protected]>
>> ---
>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 14 +++++++++++++-
>> 1 file changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
>> e92e6b03333a..8a40bba53027 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -1106,9 +1106,21 @@
>> };
>>
>> du: display@feb00000 {
>> + compatible = "renesas,du-r8a77965";
>> reg = <0 0xfeb00000 0 0x80000>,
>> <0 0xfeb90000 0 0x14>;
>> - /* placeholder */
>> + reg-names = "du", "lvds.0";
>
> The LVDS encoder has been split to a separate node in current bindings. You
> can remove the reg-names property and the second reg entry.

Done.

>
>> + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 724>,
>> + <&cpg CPG_MOD 723>,
>> + <&cpg CPG_MOD 721>,
>> + <&cpg CPG_MOD 727>;
>> + clock-names = "du.0", "du.1", "du.3", "lvds.0";
>
> And you can remove the LVDS clock as well (from both clocks and clock-names).
>
> With this fixed,
>
> Reviewed-by: Laurent Pinchart <[email protected]>

Collected, thanks.

--
Kieran


>
>> + status = "disabled";
>> +
>> + vsps = <&vspd0 0 &vspd1 0 &vspd0 1>;
>>
>> ports {
>> #address-cells = <1>;
>