2018-04-25 22:44:23

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the qcom tree

Hi Andy,

After merging the qcom tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "geni_se_select_mode" [drivers/tty/serial/qcom_geni_serial.ko] undefined!
ERROR: "geni_se_init" [drivers/tty/serial/qcom_geni_serial.ko] undefined!
ERROR: "geni_se_config_packing" [drivers/tty/serial/qcom_geni_serial.ko] undefined!
ERROR: "geni_se_resources_off" [drivers/tty/serial/qcom_geni_serial.ko] undefined!
ERROR: "geni_se_resources_on" [drivers/tty/serial/qcom_geni_serial.ko] undefined!

Probably caused by commit

eddac5af0654 ("soc: qcom: Add GENI based QUP Wrapper driver")

I have used the qcom tree from next-20180424 for today.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2018-04-26 03:41:24

by Evan Green

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the qcom tree

On Wed, Apr 25, 2018 at 3:42 PM Stephen Rothwell <[email protected]>
wrote:

> Hi Andy,

> After merging the qcom tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

> ERROR: "geni_se_select_mode" [drivers/tty/serial/qcom_geni_serial.ko]
undefined!
> ERROR: "geni_se_init" [drivers/tty/serial/qcom_geni_serial.ko] undefined!
> ERROR: "geni_se_config_packing" [drivers/tty/serial/qcom_geni_serial.ko]
undefined!
> ERROR: "geni_se_resources_off" [drivers/tty/serial/qcom_geni_serial.ko]
undefined!
> ERROR: "geni_se_resources_on" [drivers/tty/serial/qcom_geni_serial.ko]
undefined!

> Probably caused by commit

> eddac5af0654 ("soc: qcom: Add GENI based QUP Wrapper driver")

> I have used the qcom tree from next-20180424 for today.

> --
> Cheers,
> Stephen Rothwell

Guenter and I had a fix for compile test here, which had failures that
looked similar:

https://lkml.org/lkml/2018/4/18/752

I was hoping to verify myself whether or not this fixed allmodconfig, but
my machine at home is not so fast, and I must be missing something, either
in the configuration or the tree. Which tree exactly are you building?
-Evan

2018-04-26 04:57:25

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the qcom tree

Hi Evan,

On Thu, 26 Apr 2018 03:39:25 +0000 Evan Green <[email protected]> wrote:
>
> Guenter and I had a fix for compile test here, which had failures that
> looked similar:
>
> https://lkml.org/lkml/2018/4/18/752

That looks like it could very well be the problem/solution.

> I was hoping to verify myself whether or not this fixed allmodconfig, but
> my machine at home is not so fast, and I must be missing something, either
> in the configuration or the tree. Which tree exactly are you building?

I was attempting to compile my partial linux-next for today after
merging the qcom tree. So once I release linux-next, it will be commit
a72d0aa48d2e ("Merge remote-tracking branch 'omap/for-next'") plus a
merge of the qcom tree
(git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git#for-next
- which today meant commit c78d6951a806 ("Merge branch 'soc-for-4.18'
into all-for-4.18")).

I suspect that just Linus' tree merged with the qcom tree would have
been enough to cause the failure.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2018-04-26 16:44:55

by Evan Green

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the qcom tree

On Wed, Apr 25, 2018 at 9:54 PM Stephen Rothwell <[email protected]>
wrote:

> Hi Evan,

> On Thu, 26 Apr 2018 03:39:25 +0000 Evan Green <[email protected]>
wrote:
> >
> > Guenter and I had a fix for compile test here, which had failures that
> > looked similar:
> >
> > https://lkml.org/lkml/2018/4/18/752

> That looks like it could very well be the problem/solution.

> > I was hoping to verify myself whether or not this fixed allmodconfig,
but
> > my machine at home is not so fast, and I must be missing something,
either
> > in the configuration or the tree. Which tree exactly are you building?

> I was attempting to compile my partial linux-next for today after
> merging the qcom tree. So once I release linux-next, it will be commit
> a72d0aa48d2e ("Merge remote-tracking branch 'omap/for-next'") plus a
> merge of the qcom tree
> (git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git#for-next
> - which today meant commit c78d6951a806 ("Merge branch 'soc-for-4.18'
> into all-for-4.18")).

> I suspect that just Linus' tree merged with the qcom tree would have
> been enough to cause the failure.

> --
> Cheers,
> Stephen Rothwell

I've verified that the patch listed above fixes the issue for me. Andy, if
it looks okay to you, go ahead an pull it in. Apologies for the trouble,
and thanks Guenter for having builders that notice this stuff early!
-Evan

2018-04-26 21:25:06

by Andy Gross

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the qcom tree

On Thu, Apr 26, 2018 at 04:42:17PM +0000, Evan Green wrote:
> > I suspect that just Linus' tree merged with the qcom tree would have
> > been enough to cause the failure.

Sorry for missing this in my testing.

>
>
> I've verified that the patch listed above fixes the issue for me. Andy, if
> it looks okay to you, go ahead an pull it in. Apologies for the trouble,
> and thanks Guenter for having builders that notice this stuff early!
> -Evan

Thanks for looking at this Evan.


Andy