2018-05-02 20:32:12

by Andrei Vagin

Subject: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq

Signed-off-by: Andrei Vagin <[email protected]>
---
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
index aadfeaac3898..b63440fec18e 100644
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
@@ -48,7 +48,6 @@
#include "tcm_qla2xxx.h"

static struct workqueue_struct *tcm_qla2xxx_free_wq;
-static struct workqueue_struct *tcm_qla2xxx_cmd_wq;

/*
* Parse WWN.
@@ -1976,16 +1975,8 @@ static int tcm_qla2xxx_register_configfs(void)
goto out_fabric_npiv;
}

- tcm_qla2xxx_cmd_wq = alloc_workqueue("tcm_qla2xxx_cmd", 0, 0);
- if (!tcm_qla2xxx_cmd_wq) {
- ret = -ENOMEM;
- goto out_free_wq;
- }
-
return 0;

-out_free_wq:
- destroy_workqueue(tcm_qla2xxx_free_wq);
out_fabric_npiv:
target_unregister_template(&tcm_qla2xxx_npiv_ops);
out_fabric:
@@ -1995,7 +1986,6 @@ static int tcm_qla2xxx_register_configfs(void)

static void tcm_qla2xxx_deregister_configfs(void)
{
- destroy_workqueue(tcm_qla2xxx_cmd_wq);
destroy_workqueue(tcm_qla2xxx_free_wq);

target_unregister_template(&tcm_qla2xxx_ops);
--
2.14.3

2018-05-02 21:04:49

by Laurence Oberman

Subject: Re: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq

On Wed, 2018-05-02 at 13:31 -0700, Andrei Vagin wrote:
> Signed-off-by: Andrei Vagin <[email protected]>
> ---
>  drivers/scsi/qla2xxx/tcm_qla2xxx.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> index aadfeaac3898..b63440fec18e 100644
> --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> @@ -48,7 +48,6 @@
>  #include "tcm_qla2xxx.h"
>  
>  static struct workqueue_struct *tcm_qla2xxx_free_wq;
> -static struct workqueue_struct *tcm_qla2xxx_cmd_wq;
>  
>  /*
>   * Parse WWN.
> @@ -1976,16 +1975,8 @@ static int tcm_qla2xxx_register_configfs(void)
>   goto out_fabric_npiv;
>   }
>  
> - tcm_qla2xxx_cmd_wq = alloc_workqueue("tcm_qla2xxx_cmd", 0,
> 0);
> - if (!tcm_qla2xxx_cmd_wq) {
> - ret = -ENOMEM;
> - goto out_free_wq;
> - }
> -
>   return 0;
>  
> -out_free_wq:
> - destroy_workqueue(tcm_qla2xxx_free_wq);
>  out_fabric_npiv:
>   target_unregister_template(&tcm_qla2xxx_npiv_ops);
>  out_fabric:
> @@ -1995,7 +1986,6 @@ static int tcm_qla2xxx_register_configfs(void)
>  
>  static void tcm_qla2xxx_deregister_configfs(void)
>  {
> - destroy_workqueue(tcm_qla2xxx_cmd_wq);
>   destroy_workqueue(tcm_qla2xxx_free_wq);
>  
>   target_unregister_template(&tcm_qla2xxx_ops);
When I first saw this I thought, no way, it must be used, but when I
had a closer look and checked its indeed not used or even made
external.

This looks OK to me.

Reviewed-by: Laurence Oberman <[email protected]>

2018-05-08 05:26:46

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq

Andrei,

Applied to 4.18/scsi-queue. thanks!

--
Martin K. Petersen Oracle Linux Engineering