2018-05-03 19:31:28

by Greg Thelen

Subject: [PATCH] memcg: mark memcg1_events static const

Mark memcg1_events static: it's only used by memcontrol.c.
And mark it const: it's not modified.

Signed-off-by: Greg Thelen <[email protected]>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 2bd3df3d101a..c9c7e5ea0e2f 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -3083,7 +3083,7 @@ static int memcg_numa_stat_show(struct seq_file *m, void *v)
#endif /* CONFIG_NUMA */

/* Universal VM events cgroup1 shows, original sort order */
-unsigned int memcg1_events[] = {
+static const unsigned int memcg1_events[] = {
PGPGIN,
PGPGOUT,
PGFAULT,
--
2.17.0.441.gb46fe60e1d-goog

2018-05-03 19:34:26

by Michal Hocko

Subject: Re: [PATCH] memcg: mark memcg1_events static const

On Thu 03-05-18 12:29:40, Greg Thelen wrote:
> Mark memcg1_events static: it's only used by memcontrol.c.
> And mark it const: it's not modified.
>
> Signed-off-by: Greg Thelen <[email protected]>

Acked-by: Michal Hocko <[email protected]>

> ---
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 2bd3df3d101a..c9c7e5ea0e2f 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3083,7 +3083,7 @@ static int memcg_numa_stat_show(struct seq_file *m, void *v)
> #endif /* CONFIG_NUMA */
>
> /* Universal VM events cgroup1 shows, original sort order */
> -unsigned int memcg1_events[] = {
> +static const unsigned int memcg1_events[] = {
> PGPGIN,
> PGPGOUT,
> PGFAULT,
> --
> 2.17.0.441.gb46fe60e1d-goog

--
Michal Hocko
SUSE Labs