2018-05-05 20:01:10

by Mathieu Malaterre

Subject: [PATCH] driver core: add __printf verification to __ata_ehi_pushv_desc

__printf is useful to verify format and arguments. Remove the following
warning (with W=1):

drivers/ata/libata-eh.c:183:10: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Signed-off-by: Mathieu Malaterre <[email protected]>
---
drivers/ata/libata-eh.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index c016829a38fd..513b260bcff1 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -175,8 +175,8 @@ static void ata_eh_handle_port_resume(struct ata_port *ap)
{ }
#endif /* CONFIG_PM */

-static void __ata_ehi_pushv_desc(struct ata_eh_info *ehi, const char *fmt,
- va_list args)
+static __printf(2, 0) void __ata_ehi_pushv_desc(struct ata_eh_info *ehi,
+ const char *fmt, va_list args)
{
ehi->desc_len += vscnprintf(ehi->desc + ehi->desc_len,
ATA_EH_DESC_LEN - ehi->desc_len,
--
2.11.0

2018-05-07 15:40:24

by Tejun Heo

Subject: Re: [PATCH] driver core: add __printf verification to __ata_ehi_pushv_desc

On Sat, May 05, 2018 at 10:00:37PM +0200, Mathieu Malaterre wrote:
> __printf is useful to verify format and arguments. Remove the following
> warning (with W=1):
>
> drivers/ata/libata-eh.c:183:10: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
>
> Signed-off-by: Mathieu Malaterre <[email protected]>

Applied to libata/for-4.17-fixes.

Thanks.

--
tejun