2018-04-19 07:23:17

by Baolin Wang

[permalink] [raw]
Subject: [PATCH] MIPS: sni: Remove the read_persistent_clock()

The dummy read_persistent_clock() uses a timespec, which is not year 2038
safe on 32bit systems. Thus remove this obsolete interface.

Signed-off-by: Baolin Wang <[email protected]>
---
arch/mips/sni/time.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/mips/sni/time.c b/arch/mips/sni/time.c
index 0eb7d1e..dbace1f 100644
--- a/arch/mips/sni/time.c
+++ b/arch/mips/sni/time.c
@@ -171,9 +171,3 @@ void __init plat_time_init(void)
}
setup_pit_timer();
}
-
-void read_persistent_clock(struct timespec *ts)
-{
- ts->tv_sec = -1;
- ts->tv_nsec = 0;
-}
--
1.7.9.5



2018-04-20 15:27:42

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] MIPS: sni: Remove the read_persistent_clock()

On Thu, Apr 19, 2018 at 9:21 AM, Baolin Wang <[email protected]> wrote:
> The dummy read_persistent_clock() uses a timespec, which is not year 2038
> safe on 32bit systems. Thus remove this obsolete interface.
>
> Signed-off-by: Baolin Wang <[email protected]>

Looks good to me. I have a larger but incomplete patch for arch/mips
handling of read_persistent_clock(), but yours is a good start.

Acked-by: Arnd Bergmann <[email protected]>

2018-05-08 22:45:26

by James Hogan

[permalink] [raw]
Subject: Re: [PATCH] MIPS: sni: Remove the read_persistent_clock()

On Thu, Apr 19, 2018 at 03:21:06PM +0800, Baolin Wang wrote:
> The dummy read_persistent_clock() uses a timespec, which is not year 2038
> safe on 32bit systems. Thus remove this obsolete interface.
>
> Signed-off-by: Baolin Wang <[email protected]>

Thanks, Applied for 4.18

Cheers
James


Attachments:
(No filename) (306.00 B)
signature.asc (235.00 B)
Download all attachments