2018-05-09 07:52:17

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH] s390: remove no-op macro VMLINUX_SYMBOL()

VMLINUX_SYMBOL() is no-op unless CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX
is defined. It has ever been selected only by BLACKFIN and METAG.
VMLINUX_SYMBOL() is unneeded for s390-specific code.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/s390/kernel/vmlinux.lds.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/s390/kernel/vmlinux.lds.S b/arch/s390/kernel/vmlinux.lds.S
index 08d12cf..f0414f5 100644
--- a/arch/s390/kernel/vmlinux.lds.S
+++ b/arch/s390/kernel/vmlinux.lds.S
@@ -82,10 +82,10 @@ SECTIONS

. = ALIGN(PAGE_SIZE);
.init.text : AT(ADDR(.init.text) - LOAD_OFFSET) {
- VMLINUX_SYMBOL(_sinittext) = . ;
+ _sinittext = .;
INIT_TEXT
. = ALIGN(PAGE_SIZE);
- VMLINUX_SYMBOL(_einittext) = . ;
+ _einittext = .;
}

/*
--
2.7.4



2018-05-09 08:34:10

by Heiko Carstens

[permalink] [raw]
Subject: Re: [PATCH] s390: remove no-op macro VMLINUX_SYMBOL()

On Wed, May 09, 2018 at 04:51:39PM +0900, Masahiro Yamada wrote:
> VMLINUX_SYMBOL() is no-op unless CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX
> is defined. It has ever been selected only by BLACKFIN and METAG.
> VMLINUX_SYMBOL() is unneeded for s390-specific code.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/s390/kernel/vmlinux.lds.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/s390/kernel/vmlinux.lds.S b/arch/s390/kernel/vmlinux.lds.S
> index 08d12cf..f0414f5 100644
> --- a/arch/s390/kernel/vmlinux.lds.S
> +++ b/arch/s390/kernel/vmlinux.lds.S
> @@ -82,10 +82,10 @@ SECTIONS
>
> . = ALIGN(PAGE_SIZE);
> .init.text : AT(ADDR(.init.text) - LOAD_OFFSET) {
> - VMLINUX_SYMBOL(_sinittext) = . ;
> + _sinittext = .;
> INIT_TEXT
> . = ALIGN(PAGE_SIZE);
> - VMLINUX_SYMBOL(_einittext) = . ;
> + _einittext = .;

Applied, thanks.