2018-05-09 22:22:05

by Kani, Toshimitsu

Subject: [PATCH] ghes_edac: add DDR4 and NVDIMM memory types

The ghes_edac driver obtains memory type from SMBIOS type 17,
but it does not recognize DDR4 and NVDIMM types.

Add support of DDR4 and NVDIMM types. NVDIMM type is set when
memory type is DDR3/4 and non-volatile.

Reported-by: Robert Elliott <[email protected]>
Signed-off-by: Toshi Kani <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
---
drivers/edac/ghes_edac.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
index 68b6ee18bea6..d0399273018d 100644
--- a/drivers/edac/ghes_edac.c
+++ b/drivers/edac/ghes_edac.c
@@ -123,11 +123,21 @@ static void ghes_edac_dmidecode(const struct dmi_header *dh, void *arg)
dimm->mtype = MEM_FB_DDR2;
break;
case 0x18:
- if (entry->type_detail & 1 << 13)
+ if (entry->type_detail & 1 << 12)
+ dimm->mtype = MEM_NVDIMM;
+ else if (entry->type_detail & 1 << 13)
dimm->mtype = MEM_RDDR3;
else
dimm->mtype = MEM_DDR3;
break;
+ case 0x1a:
+ if (entry->type_detail & 1 << 12)
+ dimm->mtype = MEM_NVDIMM;
+ else if (entry->type_detail & 1 << 13)
+ dimm->mtype = MEM_RDDR4;
+ else
+ dimm->mtype = MEM_DDR4;
+ break;
default:
if (entry->type_detail & 1 << 6)
dimm->mtype = MEM_RMBS;

2018-05-12 12:27:45

by Borislav Petkov

Subject: Re: [PATCH] ghes_edac: add DDR4 and NVDIMM memory types

On Wed, May 09, 2018 at 04:20:30PM -0600, Toshi Kani wrote:
> The ghes_edac driver obtains memory type from SMBIOS type 17,
> but it does not recognize DDR4 and NVDIMM types.
>
> Add support of DDR4 and NVDIMM types. NVDIMM type is set when
> memory type is DDR3/4 and non-volatile.
>
> Reported-by: Robert Elliott <[email protected]>
> Signed-off-by: Toshi Kani <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> ---
> drivers/edac/ghes_edac.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)

Applied, thanks.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.