2018-05-13 23:24:09

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the imx-mxs tree

Hi Shawn,

After merging the imx-mxs tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (reg_format): /soc/ipu@2400000/port@2/endpoint@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (avoid_default_addr_size): /soc/ipu@2400000/port@2/endpoint@0: Relying on default #address-cells value

and about 7000 more lines across several files ...

It is hard tell what introduced these warnings ...

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2018-05-14 00:58:39

by Shawn Guo

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the imx-mxs tree

Hi Stephen,

On Mon, May 14, 2018 at 09:21:58AM +1000, Stephen Rothwell wrote:
> Hi Shawn,
>
> After merging the imx-mxs tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (reg_format): /soc/ipu@2400000/port@2/endpoint@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (avoid_default_addr_size): /soc/ipu@2400000/port@2/endpoint@0: Relying on default #address-cells value
>
> and about 7000 more lines across several files ...
>
> It is hard tell what introduced these warnings ...

Commit e6bb17850d1e ("ARM: dts: imx: fix IPU OF graph endpoint node
names") introduced the warnings. I will submit a patch to fix them.
Sorry for this.

Shawn

2018-05-14 13:07:22

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the imx-mxs tree

On Sun, May 13, 2018 at 7:56 PM, Shawn Guo <[email protected]> wrote:
> Hi Stephen,
>
> On Mon, May 14, 2018 at 09:21:58AM +1000, Stephen Rothwell wrote:
>> Hi Shawn,
>>
>> After merging the imx-mxs tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (reg_format): /soc/ipu@2400000/port@2/endpoint@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
>> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
>> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
>> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (avoid_default_addr_size): /soc/ipu@2400000/port@2/endpoint@0: Relying on default #address-cells value
>>
>> and about 7000 more lines across several files ...
>>
>> It is hard tell what introduced these warnings ...
>
> Commit e6bb17850d1e ("ARM: dts: imx: fix IPU OF graph endpoint node
> names") introduced the warnings. I will submit a patch to fix them.
> Sorry for this.

Well, it was the combination of that and commit ed94e3c3ceb4 ("ARM:
dts: imx6: Remove #address/#size-cells from ipu nodes"). Commit
ed94e3c3ceb4q should be reverted.

Rob

2018-05-14 13:43:35

by Shawn Guo

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the imx-mxs tree

On Mon, May 14, 2018 at 08:05:29AM -0500, Rob Herring wrote:
> On Sun, May 13, 2018 at 7:56 PM, Shawn Guo <[email protected]> wrote:
> > Hi Stephen,
> >
> > On Mon, May 14, 2018 at 09:21:58AM +1000, Stephen Rothwell wrote:
> >> Hi Shawn,
> >>
> >> After merging the imx-mxs tree, today's linux-next build (arm
> >> multi_v7_defconfig) produced this warning:
> >>
> >> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (reg_format): /soc/ipu@2400000/port@2/endpoint@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> >> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> >> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
> >> arch/arm/boot/dts/imx6dl-aristainetos_7.dtb: Warning (avoid_default_addr_size): /soc/ipu@2400000/port@2/endpoint@0: Relying on default #address-cells value
> >>
> >> and about 7000 more lines across several files ...
> >>
> >> It is hard tell what introduced these warnings ...
> >
> > Commit e6bb17850d1e ("ARM: dts: imx: fix IPU OF graph endpoint node
> > names") introduced the warnings. I will submit a patch to fix them.
> > Sorry for this.
>
> Well, it was the combination of that and commit ed94e3c3ceb4 ("ARM:
> dts: imx6: Remove #address/#size-cells from ipu nodes"). Commit
> ed94e3c3ceb4q should be reverted.

Ah, okay. I will just drop that commit then.

Shawn

2022-04-26 05:40:39

by Shawn Guo

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the imx-mxs tree

On Tue, Apr 26, 2022 at 10:06:59AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the imx-mxs tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> arch/arm/boot/dts/ls1021a-iot.dts:150.3-26: Warning (clocks_property): /soc/i2c@2180000/audio-codec@2a:clocks: cell 1 is not a phandle reference
> arch/arm/boot/dts/ls1021a-iot.dts:144.27-151.4: Warning (clocks_property): /soc/i2c@2180000/audio-codec@2a: Missing property '#clock-cells' in node /soc/interrupt-controller@1400000 or bad phandle (referred from clocks[1])
>
> Introduced by commit
>
> 23f550d5f7f6 ("ARM: dts: Add initial LS1021A IoT board dts support")

Changming,

I fixed it up with the following change. Let me know if you disagree.

diff --git a/arch/arm/boot/dts/ls1021a-iot.dts b/arch/arm/boot/dts/ls1021a-iot.dts
index bdb7186f3590..66bcdaf4b6f9 100644
--- a/arch/arm/boot/dts/ls1021a-iot.dts
+++ b/arch/arm/boot/dts/ls1021a-iot.dts
@@ -147,7 +147,7 @@ sgtl5000: audio-codec@2a {
reg = <0x2a>;
VDDA-supply = <&reg_3p3v>;
VDDIO-supply = <&reg_2p5v>;
- clocks = <&sys_mclk 1>;
+ clocks = <&sys_mclk>;
};

max1239: adc@35 {