2018-05-13 01:49:20

by Randy Dunlap

Subject: [PATCH] hexagon: fix printk format warning in setup.c

From: Randy Dunlap <[email protected]>

Fix printk format warning in hexagon/kernel/setup.c:

../arch/hexagon/kernel/setup.c: In function 'setup_arch':
../arch/hexagon/kernel/setup.c:69:2: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]

where:
extern unsigned long __phys_offset;
#define PHYS_OFFSET __phys_offset

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Richard Kuo <[email protected]>
Cc: [email protected]
---
arch/hexagon/kernel/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20180510.orig/arch/hexagon/kernel/setup.c
+++ linux-next-20180510/arch/hexagon/kernel/setup.c
@@ -66,7 +66,7 @@ void __init setup_arch(char **cmdline_p)
*/
__vmsetvec(_K_VM_event_vector);

- printk(KERN_INFO "PHYS_OFFSET=0x%08x\n", PHYS_OFFSET);
+ printk(KERN_INFO "PHYS_OFFSET=0x%08lx\n", PHYS_OFFSET);

/*
* Simulator has a few differences from the hardware.

2018-05-15 19:04:01

by Richard Kuo

Subject: Re: [PATCH] hexagon: fix printk format warning in setup.c

On Sat, May 12, 2018 at 06:48:49PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix printk format warning in hexagon/kernel/setup.c:
>
> ../arch/hexagon/kernel/setup.c: In function 'setup_arch':
> ../arch/hexagon/kernel/setup.c:69:2: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]
>
> where:
> extern unsigned long __phys_offset;
> #define PHYS_OFFSET __phys_offset
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Richard Kuo <[email protected]>
> Cc: [email protected]
> ---
> arch/hexagon/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20180510.orig/arch/hexagon/kernel/setup.c
> +++ linux-next-20180510/arch/hexagon/kernel/setup.c
> @@ -66,7 +66,7 @@ void __init setup_arch(char **cmdline_p)
> */
> __vmsetvec(_K_VM_event_vector);
>
> - printk(KERN_INFO "PHYS_OFFSET=0x%08x\n", PHYS_OFFSET);
> + printk(KERN_INFO "PHYS_OFFSET=0x%08lx\n", PHYS_OFFSET);
>
> /*
> * Simulator has a few differences from the hardware.
>
>


Acked-by: Richard Kuo <[email protected]>

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project