2018-05-22 21:30:48

by João Paulo Rechi Vita

[permalink] [raw]
Subject: [PATCH] platform/x86: asus-wireless: Fix format specifier

From: João Paulo Rechi Vita <[email protected]>

u64 should be printed with %llx instead of %x and cast to uint.

Signed-off-by: João Paulo Rechi Vita <[email protected]>
---
drivers/platform/x86/asus-wireless.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index f086469ea740..6afd011de9e5 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -72,7 +72,7 @@ static u64 asus_wireless_method(acpi_handle handle, const char *method,
acpi_handle_err(handle,
"Failed to eval method %s, param %#x (%d)\n",
method, param, s);
- acpi_handle_debug(handle, "%s returned %#x\n", method, (uint) ret);
+ acpi_handle_debug(handle, "%s returned %#llx\n", method, ret);
return ret;
}

--
2.17.0



2018-05-31 10:36:19

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH] platform/x86: asus-wireless: Fix format specifier

On Wed, May 23, 2018 at 12:29 AM, João Paulo Rechi Vita
<[email protected]> wrote:
> From: João Paulo Rechi Vita <[email protected]>
>
> u64 should be printed with %llx instead of %x and cast to uint.
>

Pushed to my review and testing queue, thanks!

> Signed-off-by: João Paulo Rechi Vita <[email protected]>
> ---
> drivers/platform/x86/asus-wireless.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
> index f086469ea740..6afd011de9e5 100644
> --- a/drivers/platform/x86/asus-wireless.c
> +++ b/drivers/platform/x86/asus-wireless.c
> @@ -72,7 +72,7 @@ static u64 asus_wireless_method(acpi_handle handle, const char *method,
> acpi_handle_err(handle,
> "Failed to eval method %s, param %#x (%d)\n",
> method, param, s);
> - acpi_handle_debug(handle, "%s returned %#x\n", method, (uint) ret);
> + acpi_handle_debug(handle, "%s returned %#llx\n", method, ret);
> return ret;
> }
>
> --
> 2.17.0
>



--
With Best Regards,
Andy Shevchenko