2018-05-22 21:32:30

by kernel test robot

Subject: [rcu:rcu/dev 98/99] kernel/rcu/rcutorture.c:1145:1: sparse: symbol '__pcpu_scope_rcu_torture_timer_rand' was not declared. Should it be static?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev
head: 477fc1978395d58ae0406293a1d963629778a39d
commit: 816e0790625af6848ef768adead22dd6302a9c41 [98/99] rcutorture: Use per-CPU random state for rcu_torture_timer()
reproduce:
# apt-get install sparse
git checkout 816e0790625af6848ef768adead22dd6302a9c41
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> kernel/rcu/rcutorture.c:1145:1: sparse: symbol '__pcpu_scope_rcu_torture_timer_rand' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

2018-05-22 21:33:34

by Fengguang Wu

Subject: [RFC PATCH rcu] rcutorture: __pcpu_scope_rcu_torture_timer_rand can be static

Fixes: 816e0790625a ("rcutorture: Use per-CPU random state for rcu_torture_timer()")
Signed-off-by: kbuild test robot <[email protected]>
---
rcutorture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index 5683bfb..a03313e 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -1142,7 +1142,7 @@ static bool rcu_torture_one_read(struct torture_random_state *trsp)
return true;
}

-DEFINE_TORTURE_RANDOM_PERCPU(rcu_torture_timer_rand);
+static DEFINE_TORTURE_RANDOM_PERCPU(rcu_torture_timer_rand);

/*
* RCU torture reader from timer handler. Dereferences rcu_torture_current,

2018-05-22 23:31:35

by Paul E. McKenney

Subject: Re: [RFC PATCH rcu] rcutorture: __pcpu_scope_rcu_torture_timer_rand can be static

On Wed, May 23, 2018 at 05:30:35AM +0800, kbuild test robot wrote:
>
> Fixes: 816e0790625a ("rcutorture: Use per-CPU random state for rcu_torture_timer()")
> Signed-off-by: kbuild test robot <[email protected]>

I folded this into the offending patch with attribution, thank you!

Thanx, Paul

> ---
> rcutorture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 5683bfb..a03313e 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -1142,7 +1142,7 @@ static bool rcu_torture_one_read(struct torture_random_state *trsp)
> return true;
> }
>
> -DEFINE_TORTURE_RANDOM_PERCPU(rcu_torture_timer_rand);
> +static DEFINE_TORTURE_RANDOM_PERCPU(rcu_torture_timer_rand);
>
> /*
> * RCU torture reader from timer handler. Dereferences rcu_torture_current,
>