2018-05-23 07:05:28

by Yue Haibing

[permalink] [raw]
Subject: [PATCH] netfilter: uapi: includes linux/types.h

gcc-7.3.0 report following warning:
./usr/include/linux/netfilter/nf_osf.h:27: found __[us]{8,16,32,64} type without #include <linux/types.h>

includes linux/types.h to fix it.

Signed-off-by: YueHaibing <[email protected]>
---
include/uapi/linux/netfilter/nf_osf.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/netfilter/nf_osf.h b/include/uapi/linux/netfilter/nf_osf.h
index 45376ea..d1dbe00 100644
--- a/include/uapi/linux/netfilter/nf_osf.h
+++ b/include/uapi/linux/netfilter/nf_osf.h
@@ -1,6 +1,8 @@
#ifndef _NF_OSF_H
#define _NF_OSF_H

+#include <linux/types.h>
+
#define MAXGENRELEN 32

#define NF_OSF_GENRE (1 << 0)
--
2.7.0




2018-05-23 07:50:55

by Pablo Neira Ayuso

[permalink] [raw]
Subject: Re: [PATCH] netfilter: uapi: includes linux/types.h

On Wed, May 23, 2018 at 03:03:26PM +0800, YueHaibing wrote:
> gcc-7.3.0 report following warning:
> ./usr/include/linux/netfilter/nf_osf.h:27: found __[us]{8,16,32,64} type without #include <linux/types.h>
>
> includes linux/types.h to fix it.

Thanks.

There's already a fix for this in the nf-next queue.

commit 01cd267bff52619a53fa05c930ea5ed53493d21a
Author: Florian Westphal <[email protected]>
Date: Tue May 8 10:05:38 2018 +0200

netfilter: fix fallout from xt/nf osf separation