2018-05-27 13:10:07

by Arushi Singhal

Subject: [PATCH] iptables-compat: homogenize error message

There is a difference between error messages in iptables and
iptables-compat:

#sudo iptables-compat -D INPUT 4
iptables: No chain/target/match by that name.

#sudo iptables -D INPUT 4
iptables: Index of deletion too big.

Now, will show same error message.

Signed-off-by: Arushi Singhal <[email protected]>
---
iptables/nft.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/iptables/nft.c b/iptables/nft.c
index e33d00f..40646f4 100644
--- a/iptables/nft.c
+++ b/iptables/nft.c
@@ -2603,7 +2603,7 @@ const char *nft_strerror(int err)
{ nft_rule_add, E2BIG, "Index of insertion too big" },
{ nft_rule_check, ENOENT, "Bad rule (does a matching rule exist in that chain?)" },
{ nft_rule_replace, ENOENT, "Index of replacement too big" },
- { nft_rule_delete_num, E2BIG, "Index of deletion too big" },
+ { nft_rule_delete_num, ENOENT, "Index of deletion too big" },
/* { TC_READ_COUNTER, E2BIG, "Index of counter too big" },
{ TC_ZERO_COUNTER, E2BIG, "Index of counter too big" }, */
{ nft_rule_add, ELOOP, "Loop found in table" },
--
2.7.4

2018-05-29 03:55:24

by Pablo Neira Ayuso

Subject: Re: [PATCH] iptables-compat: homogenize error message

On Sun, May 27, 2018 at 06:39:01PM +0530, Arushi Singhal wrote:
> There is a difference between error messages in iptables and
> iptables-compat:
>
> #sudo iptables-compat -D INPUT 4
> iptables: No chain/target/match by that name.
>
> #sudo iptables -D INPUT 4
> iptables: Index of deletion too big.
>
> Now, will show same error message.

Applied, thanks Arushi.

P.S: Just Cc: [email protected] next time. Thanks.