2018-05-29 19:08:00

by Dmitry Torokhov

[permalink] [raw]
Subject: [PATCH] platform/chrome: chromeos_laptop: fix touchpad button mapping on Celes

Celes has newer touch controller (compared to the controllers used in
older BayTrail-based devices) and so uses the same button mapping as
Samus.

This fixes the issue with mouse button being stuck in pressed state
after the first click.

Reported-by: Sultan Alsawaf <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
---
drivers/platform/chrome/chromeos_laptop.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c
index 3cecf7933f751..24326eecd7876 100644
--- a/drivers/platform/chrome/chromeos_laptop.c
+++ b/drivers/platform/chrome/chromeos_laptop.c
@@ -620,10 +620,18 @@ static const struct dmi_system_id chromeos_laptop_dmi_table[] __initconst = {
},
.driver_data = (void *)&samus,
},
+ {
+ .ident = "Samsung Chromebook 3",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
+ },
+ .driver_data = (void *)&samus,
+ },
{
/*
* Other Chromebooks with Atmel touch controllers:
- * - Celes, Winky (touchpad)
+ * - Winky (touchpad)
* - Clapper, Expresso, Rambi, Glimmer (touchscreen)
*/
.ident = "Other Chromebook",
--
2.17.0.921.gf22659ad46-goog


--
Dmitry


2018-05-29 22:13:03

by Benson Leung

[permalink] [raw]
Subject: Re: [PATCH] platform/chrome: chromeos_laptop: fix touchpad button mapping on Celes

Hi Dmitry, Hi Sultan,

On Tue, May 29, 2018 at 12:06:59PM -0700, Dmitry Torokhov wrote:
> Celes has newer touch controller (compared to the controllers used in
> older BayTrail-based devices) and so uses the same button mapping as
> Samus.
>
> This fixes the issue with mouse button being stuck in pressed state
> after the first click.
>
> Reported-by: Sultan Alsawaf <[email protected]>
> Signed-off-by: Dmitry Torokhov <[email protected]>

Applied for v4.18. Thanks.

--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
[email protected]
Chromium OS Project
[email protected]


Attachments:
(No filename) (634.00 B)
signature.asc (849.00 B)
Download all attachments