Hi all,
My qemu boots of today's powerpc linux-next kernel produced the following
boot message differences:
-Max number of cores passed to firmware: 2048 (NR_CPUS = 2048)
+Max number of cores passed to firmware: u (NR_CPUS = 2048)
Seemingly caused by commit
eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf")
--
Cheers,
Stephen Rothwell
On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> My qemu boots of today's powerpc linux-next kernel produced the following
> boot message differences:
>
> -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048)
> +Max number of cores passed to firmware: u (NR_CPUS = 2048)
>
> Seemingly caused by commit
>
> eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf")
My bad. Patch is pending (thanks Michael!):
https://patchwork.ozlabs.org/patch/921948/
> --
> Cheers,
> Stephen Rothwell
On Tue, May 29, 2018 at 1:56 PM, Mathieu Malaterre <[email protected]> wrote:
> On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell <[email protected]> wrote:
>> Hi all,
>>
>> My qemu boots of today's powerpc linux-next kernel produced the following
>> boot message differences:
>>
>> -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048)
>> +Max number of cores passed to firmware: u (NR_CPUS = 2048)
>>
>> Seemingly caused by commit
>>
>> eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf")
>
> My bad. Patch is pending (thanks Michael!):
>
> https://patchwork.ozlabs.org/patch/921948/
Nope, nevermind this is unrelated.
>> --
>> Cheers,
>> Stephen Rothwell
Michael,
On Tue, May 29, 2018 at 2:00 PM, Mathieu Malaterre <[email protected]> wrote:
> On Tue, May 29, 2018 at 1:56 PM, Mathieu Malaterre <[email protected]> wrote:
>> On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell <[email protected]> wrote:
>>> Hi all,
>>>
>>> My qemu boots of today's powerpc linux-next kernel produced the following
>>> boot message differences:
>>>
>>> -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048)
>>> +Max number of cores passed to firmware: u (NR_CPUS = 2048)
>>>
>>> Seemingly caused by commit
>>>
>>> eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf")
>>
>> My bad. Patch is pending (thanks Michael!):
>>
>> https://patchwork.ozlabs.org/patch/921948/
>
> Nope, nevermind this is unrelated.
Could you update your patch "powerpc/prom: Fix %llx usage since
prom_printf() change" to also do "powerpc/prom: Fix %u usage since
prom_printf() change"
I did not pay attention that "%u" was also not supported in prom_printf.
I may be able to provide a patch tonight, if this is not acceptable,
please revert my faulty patch. Sorry for the mess.
>>> --
>>> Cheers,
>>> Stephen Rothwell
Hi Mathieu,
On Tue, 29 May 2018 13:56:48 +0200 Mathieu Malaterre <[email protected]> wrote:
>
> On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell <[email protected]> wrote:
> > Hi all,
> >
> > My qemu boots of today's powerpc linux-next kernel produced the following
> > boot message differences:
> >
> > -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048)
> > +Max number of cores passed to firmware: u (NR_CPUS = 2048)
> >
> > Seemingly caused by commit
> >
> > eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf")
>
> My bad. Patch is pending (thanks Michael!):
>
> https://patchwork.ozlabs.org/patch/921948/
Umm, that fixes some other messages, but not this particular one.
--
Cheers,
Stephen Rothwell
Stephen,
On Tue, May 29, 2018 at 2:23 PM, Stephen Rothwell <[email protected]> wrote:
> Hi Mathieu,
>
> On Tue, 29 May 2018 13:56:48 +0200 Mathieu Malaterre <[email protected]> wrote:
>>
>> On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell <[email protected]> wrote:
>> > Hi all,
>> >
>> > My qemu boots of today's powerpc linux-next kernel produced the following
>> > boot message differences:
>> >
>> > -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048)
>> > +Max number of cores passed to firmware: u (NR_CPUS = 2048)
>> >
>> > Seemingly caused by commit
>> >
>> > eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf")
>>
>> My bad. Patch is pending (thanks Michael!):
>>
>> https://patchwork.ozlabs.org/patch/921948/
>
> Umm, that fixes some other messages, but not this particular one.
Here is what I tried to say:
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 4d62f561f272..72ebe5896c1d 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -379,6 +379,11 @@ static void __init prom_printf(const char *format, ...)
}
prom_print_dec(vs);
break;
+ case 'u':
+ ++q;
+ vs = va_arg(args, unsigned long);
+ prom_print_dec(vs);
+ break;
case 'l':
++q;
if (*q == 0)
> --
> Cheers,
> Stephen Rothwell