Subject: [PATCH] ftrace: use non-archaic spelling of failes

Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
---
kernel/trace/ftrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 8d83bcf9ef69..b218cee1f18c 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -4788,7 +4788,7 @@ ftrace_set_addr(struct ftrace_ops *ops, unsigned long ip, int remove,
* @reset - non zero to reset all filters before applying this filter.
*
* Filters denote which functions should be enabled when tracing is enabled
- * If @ip is NULL, it failes to update filter.
+ * If @ip is NULL, it fails to update filter.
*/
int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
int remove, int reset)
--
2.17.0



2018-05-31 15:17:32

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] ftrace: use non-archaic spelling of failes

On Thu, 2018-05-31 at 09:17 -0300, Thadeu Lima de Souza Cascardo wrote:
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
[]
> @@ -4788,7 +4788,7 @@ ftrace_set_addr(struct ftrace_ops *ops, unsigned long ip, int remove,
> * @reset - non zero to reset all filters before applying this filter.
> *
> * Filters denote which functions should be enabled when tracing is enabled
> - * If @ip is NULL, it failes to update filter.
> + * If @ip is NULL, it fails to update filter.
> */
> int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
> int remove, int reset)

Perhaps fix it treewide?

$ git grep -w -i failes | wc -l
8


Subject: Re: [PATCH] ftrace: use non-archaic spelling of failes

On Thu, May 31, 2018 at 08:15:45AM -0700, Joe Perches wrote:
> On Thu, 2018-05-31 at 09:17 -0300, Thadeu Lima de Souza Cascardo wrote:
> > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> []
> > @@ -4788,7 +4788,7 @@ ftrace_set_addr(struct ftrace_ops *ops, unsigned long ip, int remove,
> > * @reset - non zero to reset all filters before applying this filter.
> > *
> > * Filters denote which functions should be enabled when tracing is enabled
> > - * If @ip is NULL, it failes to update filter.
> > + * If @ip is NULL, it fails to update filter.
> > */
> > int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
> > int remove, int reset)
>
> Perhaps fix it treewide?
>
> $ git grep -w -i failes | wc -l
> 8
>

I sent patches to the respective maintainers for all of these.

Cascardo.

2018-05-31 15:22:54

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] ftrace: use non-archaic spelling of failes

On Thu, 2018-05-31 at 12:16 -0300, Thadeu Lima de Souza Cascardo wrote:
> On Thu, May 31, 2018 at 08:15:45AM -0700, Joe Perches wrote:
> > On Thu, 2018-05-31 at 09:17 -0300, Thadeu Lima de Souza Cascardo wrote:
> > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> > []
> > > @@ -4788,7 +4788,7 @@ ftrace_set_addr(struct ftrace_ops *ops, unsigned long ip, int remove,
> > > * @reset - non zero to reset all filters before applying this filter.
> > > *
> > > * Filters denote which functions should be enabled when tracing is enabled
> > > - * If @ip is NULL, it failes to update filter.
> > > + * If @ip is NULL, it fails to update filter.
> > > */
> > > int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
> > > int remove, int reset)
> >
> > Perhaps fix it treewide?
> >
> > $ git grep -w -i failes | wc -l
> > 8
>
> I sent patches to the respective maintainers for all of these.

Great, thank you.


2018-05-31 22:47:47

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] ftrace: use non-archaic spelling of failes

On Thu, 31 May 2018 09:17:01 -0300
Thadeu Lima de Souza Cascardo <[email protected]> wrote:

> Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>

Acked-by: Steven Rostedt (VMware) <[email protected]>

-- Steve

> ---
> kernel/trace/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 8d83bcf9ef69..b218cee1f18c 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -4788,7 +4788,7 @@ ftrace_set_addr(struct ftrace_ops *ops, unsigned long ip, int remove,
> * @reset - non zero to reset all filters before applying this filter.
> *
> * Filters denote which functions should be enabled when tracing is enabled
> - * If @ip is NULL, it failes to update filter.
> + * If @ip is NULL, it fails to update filter.
> */
> int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
> int remove, int reset)