2018-06-01 11:28:40

by Tiwei Bie

[permalink] [raw]
Subject: [PATCH v3] virtio: update the comments for transport features

The existing comments for transport features are outdated.
So update them to address the latest changes in the spec.

Suggested-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Tiwei Bie <[email protected]>
Reviewed-by: Cornelia Huck <[email protected]>
---
This patch is generated on top of below patch:
https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html

v3:
- Fix a typo in the commit message (Cornelia);

v2:
- Improve the comments (Cornelia);
- Improve the commit message;

include/uapi/linux/virtio_config.h | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h
index b7c1f4e7d59e..449132c76b1c 100644
--- a/include/uapi/linux/virtio_config.h
+++ b/include/uapi/linux/virtio_config.h
@@ -45,9 +45,12 @@
/* We've given up on this device. */
#define VIRTIO_CONFIG_S_FAILED 0x80

-/* Some virtio feature bits (currently bits 28 through 32) are reserved for the
- * transport being used (eg. virtio_ring), the rest are per-device feature
- * bits. */
+/*
+ * Virtio feature bits VIRTIO_TRANSPORT_F_START through
+ * VIRTIO_TRANSPORT_F_END are reserved for the transport
+ * being used (e.g. virtio_ring, virtio_pci etc.), the
+ * rest are per-device feature bits.
+ */
#define VIRTIO_TRANSPORT_F_START 28
#define VIRTIO_TRANSPORT_F_END 38

--
2.17.0



2018-06-07 16:24:14

by Stefan Hajnoczi

[permalink] [raw]
Subject: Re: [PATCH v3] virtio: update the comments for transport features

On Fri, Jun 01, 2018 at 07:26:32PM +0800, Tiwei Bie wrote:
> The existing comments for transport features are outdated.
> So update them to address the latest changes in the spec.
>
> Suggested-by: Michael S. Tsirkin <[email protected]>
> Signed-off-by: Tiwei Bie <[email protected]>
> Reviewed-by: Cornelia Huck <[email protected]>
> ---
> This patch is generated on top of below patch:
> https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html
>
> v3:
> - Fix a typo in the commit message (Cornelia);
>
> v2:
> - Improve the comments (Cornelia);
> - Improve the commit message;
>
> include/uapi/linux/virtio_config.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <[email protected]>


Attachments:
(No filename) (776.00 B)
signature.asc (465.00 B)
Download all attachments