2018-06-01 19:48:27

by kernel test robot

Subject: [net-next:master 379/380] drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:144:5: sparse: symbol 'mvpp2_percpu_read_relaxed' was not declared. Should it be static?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 07f7ee6ec0e2193f1abca36cd7154986aec4893e
commit: db9d7d36eecc8926f03a8f2e46781887577b3353 [379/380] net: mvpp2: Split the PPv2 driver to a dedicated directory
reproduce:
# apt-get install sparse
git checkout db9d7d36eecc8926f03a8f2e46781887577b3353
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:144:5: sparse: symbol 'mvpp2_percpu_read_relaxed' was not declared. Should it be static?
>> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:1699:15: sparse: expression using sizeof(void)
>> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2620:36: sparse: incorrect type in argument 2 (different base types) @@ expected int [signed] l3_proto @@ got restricted __be1int [signed] l3_proto @@
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2620:36: expected int [signed] l3_proto
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2620:36: got restricted __be16 [usertype] protocol
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2874:28: sparse: expression using sizeof(void)
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2874:28: sparse: expression using sizeof(void)
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2885:34: sparse: expression using sizeof(void)
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:2885:34: sparse: expression using sizeof(void)

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

2018-06-01 19:48:08

by Fengguang Wu

Subject: [RFC PATCH net-next] net: mvpp2: mvpp2_percpu_read_relaxed() can be static

Fixes: db9d7d36eecc ("net: mvpp2: Split the PPv2 driver to a dedicated directory")
Signed-off-by: kbuild test robot <[email protected]>
---
mvpp2_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 45622bf..0319ed9 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -141,7 +141,7 @@ void mvpp2_percpu_write_relaxed(struct mvpp2 *priv, int cpu,
writel_relaxed(data, priv->swth_base[cpu] + offset);
}

-u32 mvpp2_percpu_read_relaxed(struct mvpp2 *priv, int cpu,
+static u32 mvpp2_percpu_read_relaxed(struct mvpp2 *priv, int cpu,
u32 offset)
{
return readl_relaxed(priv->swth_base[cpu] + offset);

2018-06-04 15:38:26

by David Miller

Subject: Re: [RFC PATCH net-next] net: mvpp2: mvpp2_percpu_read_relaxed() can be static

From: kbuild test robot <[email protected]>
Date: Sat, 2 Jun 2018 03:46:13 +0800

>
> Fixes: db9d7d36eecc ("net: mvpp2: Split the PPv2 driver to a dedicated directory")
> Signed-off-by: kbuild test robot <[email protected]>

Applied to net-next, thank you.