2018-06-08 14:56:03

by Avi Kivity

[permalink] [raw]
Subject: [PATCH v1] aio: mark __aio_sigset::sigmask const

io_pgetevents() will not change the signal mask. Mark it const
to make it clear and to reduce the need for casts in user code.

Signed-off-by: Avi Kivity <[email protected]>
---
include/uapi/linux/aio_abi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h
index ed0185945bb2..cdf115b03761 100644
--- a/include/uapi/linux/aio_abi.h
+++ b/include/uapi/linux/aio_abi.h
@@ -106,11 +106,11 @@ struct iocb {

#undef IFBIG
#undef IFLITTLE

struct __aio_sigset {
- sigset_t __user *sigmask;
+ const sigset_t __user *sigmask;
size_t sigsetsize;
};

#endif /* __LINUX__AIO_ABI_H */

--
2.14.4



2018-06-11 06:49:19

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH v1] aio: mark __aio_sigset::sigmask const

On Fri, Jun 08, 2018 at 05:55:05PM +0300, Avi Kivity wrote:
> io_pgetevents() will not change the signal mask. Mark it const
> to make it clear and to reduce the need for casts in user code.
>
> Signed-off-by: Avi Kivity <[email protected]>

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>

2018-06-14 12:08:48

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH v1] aio: mark __aio_sigset::sigmask const

On Fri, Jun 08, 2018 at 05:55:05PM +0300, Avi Kivity wrote:
> io_pgetevents() will not change the signal mask. Mark it const
> to make it clear and to reduce the need for casts in user code.
>
> Signed-off-by: Avi Kivity <[email protected]>

Al, can you pick this one and the masking fix before -rc1?

> ---
> include/uapi/linux/aio_abi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h
> index ed0185945bb2..cdf115b03761 100644
> --- a/include/uapi/linux/aio_abi.h
> +++ b/include/uapi/linux/aio_abi.h
> @@ -106,11 +106,11 @@ struct iocb {
>
> #undef IFBIG
> #undef IFLITTLE
>
> struct __aio_sigset {
> - sigset_t __user *sigmask;
> + const sigset_t __user *sigmask;
> size_t sigsetsize;
> };
>
> #endif /* __LINUX__AIO_ABI_H */
>
> --
> 2.14.4
---end quoted text---