2018-06-08 20:15:07

by kernel test robot

Subject: [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev
head: f20dfe840ba05efdc4071106cffa31cb67cf6bc8
commit: 814ee31d1f906ad00daccb58944ab16fa279690c [114/116] fixup! EXP iommu: Placeholder for fix in mainline
reproduce:
# apt-get install sparse
git checkout 814ee31d1f906ad00daccb58944ab16fa279690c
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

drivers/iommu/amd_iommu.c:3539:30: sparse: expression using sizeof(void)
drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
>> drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

2018-06-08 20:13:40

by Fengguang Wu

Subject: [RFC PATCH rcu] fixup! EXP iommu: stupid_workaround() can be static

Fixes: 814ee31d1f90 ("fixup! EXP iommu: Placeholder for fix in mainline")
Signed-off-by: kbuild test robot <[email protected]>
---
amd_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 46519d0..00dcafe 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3563,7 +3563,7 @@ EXPORT_SYMBOL(amd_iommu_device_info);
static struct irq_chip amd_ir_chip;
static DEFINE_SPINLOCK(iommu_table_lock);

-void __maybe_unused stupid_workaround(void)
+static void __maybe_unused stupid_workaround(void)
{
spin_lock(&iommu_table_lock);
spin_unlock(&iommu_table_lock);

2018-06-09 06:16:56

by Paul E. McKenney

Subject: Re: [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?

On Sat, Jun 09, 2018 at 04:11:26AM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev
> head: f20dfe840ba05efdc4071106cffa31cb67cf6bc8
> commit: 814ee31d1f906ad00daccb58944ab16fa279690c [114/116] fixup! EXP iommu: Placeholder for fix in mainline
> reproduce:
> # apt-get install sparse
> git checkout 814ee31d1f906ad00daccb58944ab16fa279690c
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
> drivers/iommu/amd_iommu.c:3539:30: sparse: expression using sizeof(void)
> drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
> drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
> >> drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.

This whole thing disappears when I rebase to v4.18-rc1. ;-)

Thanx, Paul