2018-06-14 21:41:35

by Haiyang Zhang

Subject: [PATCH net-next] hv_netvsc: Fix the variable sizes in ipsecv2 and rsc offload

From: Haiyang Zhang <[email protected]>

These fields in struct ndis_ipsecv2_offload and struct ndis_rsc_offload
are one byte according to the specs. This patch defines them with the
right size.

Signed-off-by: Haiyang Zhang <[email protected]>
---
drivers/net/hyperv/hyperv_net.h | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index 23304aca25f9..84eaaa6368a2 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@ -1277,17 +1277,17 @@ struct ndis_lsov2_offload {

struct ndis_ipsecv2_offload {
u32 encap;
- u16 ip6;
- u16 ip4opt;
- u16 ip6ext;
- u16 ah;
- u16 esp;
- u16 ah_esp;
- u16 xport;
- u16 tun;
- u16 xport_tun;
- u16 lso;
- u16 extseq;
+ u8 ip6;
+ u8 ip4opt;
+ u8 ip6ext;
+ u8 ah;
+ u8 esp;
+ u8 ah_esp;
+ u8 xport;
+ u8 tun;
+ u8 xport_tun;
+ u8 lso;
+ u8 extseq;
u32 udp_esp;
u32 auth;
u32 crypto;
@@ -1295,8 +1295,8 @@ struct ndis_ipsecv2_offload {
};

struct ndis_rsc_offload {
- u16 ip4;
- u16 ip6;
+ u8 ip4;
+ u8 ip6;
};

struct ndis_encap_offload {
--
2.17.1

2018-06-15 00:00:59

by David Miller

Subject: Re: [PATCH net-next] hv_netvsc: Fix the variable sizes in ipsecv2 and rsc offload

Bug fixes should be targetted at net, not net-next. Furthermore,
net-next is closed.

2018-06-15 01:33:07

by Haiyang Zhang

Subject: RE: [PATCH net-next] hv_netvsc: Fix the variable sizes in ipsecv2 and rsc offload

> -----Original Message-----
> From: David Miller <[email protected]>
> Sent: Thursday, June 14, 2018 8:00 PM
> To: Haiyang Zhang <[email protected]>; [email protected]
> Cc: [email protected]; KY Srinivasan <[email protected]>; Stephen
> Hemminger <[email protected]>; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: Re: [PATCH net-next] hv_netvsc: Fix the variable sizes in ipsecv2 and
> rsc offload
>
>
> Bug fixes should be targetted at net, not net-next. Furthermore, net-next is
> closed.

Thanks for the reminder. I just sent out the patch to "net" tree.

Thanks,
- Haiyang