2018-06-18 15:45:23

by Emmanuel Vadot

[permalink] [raw]
Subject: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property

The RIoTboard debug uart is connected to serial1.
Add a chosen property in the DTS so OS knows what serial port to use for
the console.

Signed-off-by: Emmanuel Vadot <[email protected]>
---
arch/arm/boot/dts/imx6dl-riotboard.dts | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
index 2e98c92adff7..315d2ae6fa45 100644
--- a/arch/arm/boot/dts/imx6dl-riotboard.dts
+++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
@@ -19,6 +19,10 @@
reg = <0x10000000 0x40000000>;
};

+ chosen {
+ stdout-path = "serial1:115200n8";
+ };
+
regulators {
compatible = "simple-bus";
#address-cells = <1>;
--
2.17.0



2018-06-18 15:48:02

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property

On Mon, Jun 18, 2018 at 12:42 PM, Emmanuel Vadot <[email protected]> wrote:
> The RIoTboard debug uart is connected to serial1.
> Add a chosen property in the DTS so OS knows what serial port to use for
> the console.
>
> Signed-off-by: Emmanuel Vadot <[email protected]>

Reviewed-by: Fabio Estevam <[email protected]>

2018-06-18 16:04:34

by Lucas Stach

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property

Am Montag, den 18.06.2018, 17:42 +0200 schrieb Emmanuel Vadot:
> The RIoTboard debug uart is connected to serial1.
> Add a chosen property in the DTS so OS knows what serial port to use for
> the console.
>
> > Signed-off-by: Emmanuel Vadot <[email protected]>
> ---
>  arch/arm/boot/dts/imx6dl-riotboard.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
> index 2e98c92adff7..315d2ae6fa45 100644
> --- a/arch/arm/boot/dts/imx6dl-riotboard.dts
> +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
> @@ -19,6 +19,10 @@
> >   reg = <0x10000000 0x40000000>;
> >   };
>  
> > + chosen {
> + stdout-path = "serial1:115200n8";

If there a reason to deviate from the "stdout-path = &uart1;" notation
used by other i.MX boards?

Regards,
Lucas

> + };
> +
> >   regulators {
> >   compatible = "simple-bus";
> >   #address-cells = <1>;

2018-06-18 16:38:27

by Emmanuel Vadot

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property

On Mon, 18 Jun 2018 18:03:17 +0200
Lucas Stach <[email protected]> wrote:

> Am Montag, den 18.06.2018, 17:42 +0200 schrieb Emmanuel Vadot:
> > The RIoTboard debug uart is connected to serial1.
> > Add a chosen property in the DTS so OS knows what serial port to use for
> > the console.
> >
> > > Signed-off-by: Emmanuel Vadot <[email protected]>
> > ---
> > ?arch/arm/boot/dts/imx6dl-riotboard.dts | 4 ++++
> > ?1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
> > index 2e98c92adff7..315d2ae6fa45 100644
> > --- a/arch/arm/boot/dts/imx6dl-riotboard.dts
> > +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
> > @@ -19,6 +19,10 @@
> > > ? reg = <0x10000000 0x40000000>;
> > > ? };
> > ?
> > > + chosen {
> > + stdout-path = "serial1:115200n8";
>
> If there a reason to deviate from the "stdout-path = &uart1;" notation
> used by other i.MX boards?
>
> Regards,
> Lucas

This is, AFAIK, the proper way to specify the stdout-path.
See
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/chosen.txt#L31

Cheers,

> > + };
> > +
> > > ? regulators {
> > > ? compatible = "simple-bus";
> > > ? #address-cells = <1>;
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


--
Emmanuel Vadot <[email protected]> <[email protected]>

2018-06-28 02:52:25

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6: RIoTboard Add chosen stdout-path property

On Mon, Jun 18, 2018 at 05:42:57PM +0200, Emmanuel Vadot wrote:
> The RIoTboard debug uart is connected to serial1.
> Add a chosen property in the DTS so OS knows what serial port to use for
> the console.
>
> Signed-off-by: Emmanuel Vadot <[email protected]>

Applied, thanks.