2018-06-18 14:27:15

by Arnd Bergmann

Subject: [PATCH] tee: replace getnstimeofday64() with ktime_get_real_ts64()

The two do the same thing, but we want to have a consistent
naming in the kernel.

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/tee/optee/rpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c
index 41aea12e2bcc..b45c73dd37a5 100644
--- a/drivers/tee/optee/rpc.c
+++ b/drivers/tee/optee/rpc.c
@@ -48,7 +48,7 @@ static void handle_rpc_func_cmd_get_time(struct optee_msg_arg *arg)
OPTEE_MSG_ATTR_TYPE_VALUE_OUTPUT)
goto bad;

- getnstimeofday64(&ts);
+ ktime_get_real_ts64(&ts);
arg->params[0].u.value.a = ts.tv_sec;
arg->params[0].u.value.b = ts.tv_nsec;

--
2.9.0

2018-06-19 13:38:38

by Jens Wiklander

Subject: Re: [PATCH] tee: replace getnstimeofday64() with ktime_get_real_ts64()

On Mon, Jun 18, 2018 at 04:24:56PM +0200, Arnd Bergmann wrote:
> The two do the same thing, but we want to have a consistent
> naming in the kernel.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/tee/optee/rpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c
> index 41aea12e2bcc..b45c73dd37a5 100644
> --- a/drivers/tee/optee/rpc.c
> +++ b/drivers/tee/optee/rpc.c
> @@ -48,7 +48,7 @@ static void handle_rpc_func_cmd_get_time(struct optee_msg_arg *arg)
> OPTEE_MSG_ATTR_TYPE_VALUE_OUTPUT)
> goto bad;
>
> - getnstimeofday64(&ts);
> + ktime_get_real_ts64(&ts);
> arg->params[0].u.value.a = ts.tv_sec;
> arg->params[0].u.value.b = ts.tv_nsec;
>
> --
> 2.9.0
>

Looks good.

Acked-by: Jens Wiklander <[email protected]>

Thanks,
Jens

2018-06-19 14:07:42

by Arnd Bergmann

Subject: Re: [PATCH] tee: replace getnstimeofday64() with ktime_get_real_ts64()

On Tue, Jun 19, 2018 at 3:37 PM, Jens Wiklander
<[email protected]> wrote:
> On Mon, Jun 18, 2018 at 04:24:56PM +0200, Arnd Bergmann wrote:
>> The two do the same thing, but we want to have a consistent
>> naming in the kernel.
>>
>> Signed-off-by: Arnd Bergmann <[email protected]>
>> ---
>> drivers/tee/optee/rpc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c
>> index 41aea12e2bcc..b45c73dd37a5 100644
>> --- a/drivers/tee/optee/rpc.c
>> +++ b/drivers/tee/optee/rpc.c
>> @@ -48,7 +48,7 @@ static void handle_rpc_func_cmd_get_time(struct optee_msg_arg *arg)
>> OPTEE_MSG_ATTR_TYPE_VALUE_OUTPUT)
>> goto bad;
>>
>> - getnstimeofday64(&ts);
>> + ktime_get_real_ts64(&ts);
>> arg->params[0].u.value.a = ts.tv_sec;
>> arg->params[0].u.value.b = ts.tv_nsec;
>>
>> --
>> 2.9.0
>>
>
> Looks good.
>
> Acked-by: Jens Wiklander <[email protected]>

Thanks for the review. Can you pick it up in your tree?

Arnd

2018-06-19 14:25:10

by Jens Wiklander

Subject: Re: [PATCH] tee: replace getnstimeofday64() with ktime_get_real_ts64()

On Tue, Jun 19, 2018 at 04:05:38PM +0200, Arnd Bergmann wrote:
> On Tue, Jun 19, 2018 at 3:37 PM, Jens Wiklander
> <[email protected]> wrote:
> > On Mon, Jun 18, 2018 at 04:24:56PM +0200, Arnd Bergmann wrote:
> >> The two do the same thing, but we want to have a consistent
> >> naming in the kernel.
> >>
> >> Signed-off-by: Arnd Bergmann <[email protected]>
> >> ---
> >> drivers/tee/optee/rpc.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c
> >> index 41aea12e2bcc..b45c73dd37a5 100644
> >> --- a/drivers/tee/optee/rpc.c
> >> +++ b/drivers/tee/optee/rpc.c
> >> @@ -48,7 +48,7 @@ static void handle_rpc_func_cmd_get_time(struct optee_msg_arg *arg)
> >> OPTEE_MSG_ATTR_TYPE_VALUE_OUTPUT)
> >> goto bad;
> >>
> >> - getnstimeofday64(&ts);
> >> + ktime_get_real_ts64(&ts);
> >> arg->params[0].u.value.a = ts.tv_sec;
> >> arg->params[0].u.value.b = ts.tv_nsec;
> >>
> >> --
> >> 2.9.0
> >>
> >
> > Looks good.
> >
> > Acked-by: Jens Wiklander <[email protected]>
>
> Thanks for the review. Can you pick it up in your tree?

OK, I'll pick it up.

Thanks,
Jens