2018-06-23 06:30:28

by Joe Perches

Subject: [PATCH] MIPS: ath25: Convert random_ether_addr to eth_random_addr

random_ether_addr is a #define for eth_random_addr which is
generally preferred in kernel code by ~3:1

Convert the uses of random_ether_addr to enable removing the #define

Signed-off-by: Joe Perches <[email protected]>
---
arch/mips/ath25/board.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/mips/ath25/board.c b/arch/mips/ath25/board.c
index 6d11ae581ea7..989e71015ee6 100644
--- a/arch/mips/ath25/board.c
+++ b/arch/mips/ath25/board.c
@@ -146,10 +146,10 @@ int __init ath25_find_config(phys_addr_t base, unsigned long size)
pr_info("Fixing up empty mac addresses\n");
config->reset_config_gpio = 0xffff;
config->sys_led_gpio = 0xffff;
- random_ether_addr(config->wlan0_mac);
+ eth_random_addr(config->wlan0_mac);
config->wlan0_mac[0] &= ~0x06;
- random_ether_addr(config->enet0_mac);
- random_ether_addr(config->enet1_mac);
+ eth_random_addr(config->enet0_mac);
+ eth_random_addr(config->enet1_mac);
}
}

--
2.15.0

2018-06-29 06:22:34

by Paul Burton

Subject: Re: [PATCH] MIPS: ath25: Convert random_ether_addr to eth_random_addr

Hi Joe,

On Fri, Jun 22, 2018 at 11:29:28PM -0700, Joe Perches wrote:
> random_ether_addr is a #define for eth_random_addr which is
> generally preferred in kernel code by ~3:1
>
> Convert the uses of random_ether_addr to enable removing the #define
>
> Signed-off-by: Joe Perches <[email protected]>
> ---
> arch/mips/ath25/board.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Applied to mips-next for 4.19.

Thanks,
Paul