2018-06-29 06:27:30

by Nick Dyer

Subject: [PATCH v1] ARM: dts: imx51-zii-rdu1: correct touchscreen axis inversion

The RMI4 touchscreen driver applied inversion and axis swap in the
wrong order, violating the DT binding for those properties. This was fixed in
645a397, so correct the RDU1 DT to apply the inversion to the
correct axis.

Tested on Zii RDU1 00-5105-30 rev B

Signed-off-by: Nick Dyer <[email protected]>
---
arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index 68f5c1d5ecd0..b1d83fb08150 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -553,7 +553,7 @@

rmi4-f11@11 {
reg = <0x11>;
- touchscreen-inverted-y;
+ touchscreen-inverted-x;
touchscreen-swapped-x-y;
syna,sensor-type = <1>;
};
--
2.17.1

2018-06-29 12:52:23

by Lucas Stach

Subject: Re: [PATCH v1] ARM: dts: imx51-zii-rdu1: correct touchscreen axis inversion

Am Donnerstag, den 28.06.2018, 23:56 +0100 schrieb Nick Dyer:
> The RMI4 touchscreen driver applied inversion and axis swap in the
> wrong order, violating the DT binding for those properties. This was fixed in
> 645a397, so correct the RDU1 DT to apply the inversion to the
> correct axis.
>
> Tested on Zii RDU1 00-5105-30 rev B
>
> Signed-off-by: Nick Dyer <[email protected]>

Reviewed-by: Lucas Stach <[email protected]>

> ---
>  arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index 68f5c1d5ecd0..b1d83fb08150 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -553,7 +553,7 @@
>  
> >   rmi4-f11@11 {
> >   reg = <0x11>;
> > - touchscreen-inverted-y;
> > + touchscreen-inverted-x;
> >   touchscreen-swapped-x-y;
> >   syna,sensor-type = <1>;
> >   };

2018-07-03 06:13:24

by Shawn Guo

Subject: Re: [PATCH v1] ARM: dts: imx51-zii-rdu1: correct touchscreen axis inversion

On Thu, Jun 28, 2018 at 11:56:26PM +0100, Nick Dyer wrote:
> The RMI4 touchscreen driver applied inversion and axis swap in the
> wrong order, violating the DT binding for those properties. This was fixed in
> 645a397, so correct the RDU1 DT to apply the inversion to the
> correct axis.
>
> Tested on Zii RDU1 00-5105-30 rev B
>
> Signed-off-by: Nick Dyer <[email protected]>

Applied, thanks.