2018-07-02 07:22:24

by Colin King

Subject: [PATCH] partitions/ldm: remove redundant pointer dgrp

From: Colin Ian King <[email protected]>

Pointer dgrp is being assigned but is never used hence it is redundant
and can be removed.

Cleans up clang warning:
warning: variable 'dgrp' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <[email protected]>
---
block/partitions/ldm.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/block/partitions/ldm.c b/block/partitions/ldm.c
index 0417937dfe99..16766f267559 100644
--- a/block/partitions/ldm.c
+++ b/block/partitions/ldm.c
@@ -830,7 +830,6 @@ static bool ldm_parse_dgr4 (const u8 *buffer, int buflen, struct vblk *vb)
{
char buf[64];
int r_objid, r_name, r_id1, r_id2, len;
- struct vblk_dgrp *dgrp;

BUG_ON (!buffer || !vb);

@@ -853,8 +852,6 @@ static bool ldm_parse_dgr4 (const u8 *buffer, int buflen, struct vblk *vb)
if (len != get_unaligned_be32(buffer + 0x14))
return false;

- dgrp = &vb->vblk.dgrp;
-
ldm_get_vstr (buffer + 0x18 + r_objid, buf, sizeof (buf));
return true;
}
--
2.17.1

2018-07-02 14:28:09

by Jens Axboe

Subject: Re: [PATCH] partitions/ldm: remove redundant pointer dgrp

On 7/2/18 1:13 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Pointer dgrp is being assigned but is never used hence it is redundant
> and can be removed.
>
> Cleans up clang warning:
> warning: variable 'dgrp' set but not used [-Wunused-but-set-variable]

Applied for 4.19, thanks.

--
Jens Axboe