2018-07-02 08:15:31

by Colin King

Subject: [PATCH] paride: remove redundant variable n

From: Colin Ian King <[email protected]>

Variable n is being assigned but is never used hence it is redundant
and can be removed. Also put spacing between variables in declaration
to clean up checkpatch warnings.

Cleans up clang warning:
warning: variable 'n' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/block/paride/bpck.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/paride/bpck.c b/drivers/block/paride/bpck.c
index 4f27e7392e38..89a96786f6ae 100644
--- a/drivers/block/paride/bpck.c
+++ b/drivers/block/paride/bpck.c
@@ -347,7 +347,7 @@ static int bpck_test_proto( PIA *pi, char * scratch, int verbose )

static void bpck_read_eeprom ( PIA *pi, char * buf )

-{ int i,j,k,n,p,v,f, om, od;
+{ int i, j, k, p, v, f, om, od;

bpck_force_spp(pi);

@@ -356,7 +356,6 @@ static void bpck_read_eeprom ( PIA *pi, char * buf )

bpck_connect(pi);

- n = 0;
WR(4,0);
for (i=0;i<64;i++) {
WR(6,8);
--
2.17.1

2018-07-02 14:29:47

by Jens Axboe

Subject: Re: [PATCH] paride: remove redundant variable n

On 7/2/18 2:14 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Variable n is being assigned but is never used hence it is redundant
> and can be removed. Also put spacing between variables in declaration
> to clean up checkpatch warnings.
>
> Cleans up clang warning:
> warning: variable 'n' set but not used [-Wunused-but-set-variable]

Applied for 4.19, thanks.

--
Jens Axboe