2018-07-02 18:38:54

by Gustavo A. R. Silva

Subject: [PATCH] block/loop: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/block/loop.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index d6b6f43..ac47c23 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1611,6 +1611,7 @@ static int lo_compat_ioctl(struct block_device *bdev, fmode_t mode,
case LOOP_GET_STATUS64:
case LOOP_SET_STATUS64:
arg = (unsigned long) compat_ptr(arg);
+ /* fall through */
case LOOP_SET_FD:
case LOOP_CHANGE_FD:
err = lo_ioctl(bdev, mode, cmd, arg);
--
2.7.4

2018-07-02 21:13:31

by Jens Axboe

Subject: Re: [PATCH] block/loop: mark expected switch fall-through

On 7/2/18 11:52 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.

Applied, thanks.

--
Jens Axboe