2018-06-27 02:04:06

by nathan.d.ciobanu

Subject: [PATCH] thunderbolt: fix small typo in variable name

From: Nathan Ciobanu <[email protected]>

Fixes small variable name typo and the associated
checkpatch spelling warning

Signed-off-by: Nathan Ciobanu <[email protected]>
---
drivers/thunderbolt/tb_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h
index 5d94142afda6..693b0353c3fe 100644
--- a/drivers/thunderbolt/tb_regs.h
+++ b/drivers/thunderbolt/tb_regs.h
@@ -202,7 +202,7 @@ struct tb_regs_port_header {
/* DWORD 5 */
u32 max_in_hop_id:11;
u32 max_out_hop_id:11;
- u32 __unkown4:10;
+ u32 __unknown4:10;
/* DWORD 6 */
u32 __unknown5;
/* DWORD 7 */
--
1.9.1

2018-06-27 11:09:00

by Mika Westerberg

Subject: Re: [PATCH] thunderbolt: fix small typo in variable name

On Tue, Jun 26, 2018 at 04:34:20PM -0700, [email protected] wrote:
> From: Nathan Ciobanu <[email protected]>
>
> Fixes small variable name typo and the associated
> checkpatch spelling warning
>
> Signed-off-by: Nathan Ciobanu <[email protected]>

Applied to thunderbolt.git/next, thanks!

2018-07-07 08:20:44

by Lukas Wunner

Subject: Re: [PATCH] thunderbolt: fix small typo in variable name

On Tue, Jun 26, 2018 at 04:34:20PM -0700, [email protected] wrot> Fixes small variable name typo and the associated
> checkpatch spelling warning
>
> Signed-off-by: Nathan Ciobanu <[email protected]>
> ---
> drivers/thunderbolt/tb_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h
> index 5d94142afda6..693b0353c3fe 100644
> --- a/drivers/thunderbolt/tb_regs.h
> +++ b/drivers/thunderbolt/tb_regs.h
> @@ -202,7 +202,7 @@ struct tb_regs_port_header {
> /* DWORD 5 */
> u32 max_in_hop_id:11;
> u32 max_out_hop_id:11;
> - u32 __unkown4:10;
> + u32 __unknown4:10;
> /* DWORD 6 */
> u32 __unknown5;
> /* DWORD 7 */

This is not an improvement. The bitfield is marked unknown because
its meaning hasn't been reverse-engineered yet. But you work for
Intel, presumably you don't have to reverse-engineer the bitfield's
meaning because you know it or can find out about it.

So please submit a patch that changes the name to the bitfield's
actual meaning.

Thanks,

Lukas

2018-07-07 11:11:39

by Mika Westerberg

Subject: Re: [PATCH] thunderbolt: fix small typo in variable name

On Sat, Jul 07, 2018 at 10:19:50AM +0200, Lukas Wunner wrote:
> On Tue, Jun 26, 2018 at 04:34:20PM -0700, [email protected] wrot> Fixes small variable name typo and the associated
> > checkpatch spelling warning
> >
> > Signed-off-by: Nathan Ciobanu <[email protected]>
> > ---
> > drivers/thunderbolt/tb_regs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h
> > index 5d94142afda6..693b0353c3fe 100644
> > --- a/drivers/thunderbolt/tb_regs.h
> > +++ b/drivers/thunderbolt/tb_regs.h
> > @@ -202,7 +202,7 @@ struct tb_regs_port_header {
> > /* DWORD 5 */
> > u32 max_in_hop_id:11;
> > u32 max_out_hop_id:11;
> > - u32 __unkown4:10;
> > + u32 __unknown4:10;
> > /* DWORD 6 */
> > u32 __unknown5;
> > /* DWORD 7 */
>
> This is not an improvement. The bitfield is marked unknown because
> its meaning hasn't been reverse-engineered yet. But you work for
> Intel, presumably you don't have to reverse-engineer the bitfield's
> meaning because you know it or can find out about it.
>
> So please submit a patch that changes the name to the bitfield's
> actual meaning.

It is an improvement since it fixes what it says (the typo). Besides the
patch is already applied.