2018-07-09 09:45:47

by Esben Haabendal

Subject: [PATCH v2 4/4] arm: dts: ls1021a: Enable I2C DMA support

From: Esben Haabendal <[email protected]>

Gives substantial performance improvement for transfers larger than 16
bytes (DMA_THRESHOLD). Smaller transfers are unaffected.

Signed-off-by: Esben Haabendal <[email protected]>
---
arch/arm/boot/dts/ls1021a.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index c55d479971cc..1e5640701c65 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -363,6 +363,8 @@
interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "i2c";
clocks = <&clockgen 4 1>;
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 39>, <&edma0 1 38>;
status = "disabled";
};

@@ -374,6 +376,8 @@
interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "i2c";
clocks = <&clockgen 4 1>;
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 37>, <&edma0 1 36>;
status = "disabled";
};

@@ -385,6 +389,8 @@
interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "i2c";
clocks = <&clockgen 4 1>;
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 35>, <&edma0 1 34>;
status = "disabled";
};

--
2.18.0

2018-07-24 08:05:00

by Uwe Kleine-König

Subject: Re: [PATCH v2 4/4] arm: dts: ls1021a: Enable I2C DMA support

Hello,

expanding Cc a bit to include Shawn and the kernel teams of Pengutronix
and NXP.

On Mon, Jul 09, 2018 at 11:43:04AM +0200, Esben Haabendal wrote:
> From: Esben Haabendal <[email protected]>
>
> Gives substantial performance improvement for transfers larger than 16
> bytes (DMA_THRESHOLD). Smaller transfers are unaffected.
>
> Signed-off-by: Esben Haabendal <[email protected]>
> ---
> arch/arm/boot/dts/ls1021a.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index c55d479971cc..1e5640701c65 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -363,6 +363,8 @@
> interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "i2c";
> clocks = <&clockgen 4 1>;
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 39>, <&edma0 1 38>;
> status = "disabled";
> };
>
> @@ -374,6 +376,8 @@
> interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "i2c";
> clocks = <&clockgen 4 1>;
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 37>, <&edma0 1 36>;
> status = "disabled";
> };
>
> @@ -385,6 +389,8 @@
> interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "i2c";
> clocks = <&clockgen 4 1>;
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 35>, <&edma0 1 34>;
> status = "disabled";
> };

This is a bit orthogonal to the other changes in this series and needs
at least an ack from Shawn. Looks ok in my eyes.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |