2018-07-09 21:53:22

by Gustavo A. R. Silva

Subject: [PATCH] backlight: adp8860: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/video/backlight/adp8860_bl.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
index 16119bd..f1dc41c 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/backlight/adp8860_bl.c
@@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client,
switch (ADP8860_MANID(reg_val)) {
case ADP8863_MANUFID:
data->gdwn_dis = !!pdata->gdwn_dis;
+ /* fall through */
case ADP8860_MANUFID:
data->en_ambl_sens = !!pdata->en_ambl_sens;
break;
--
2.7.4

2018-07-10 05:25:33

by Lee Jones

Subject: Re: [PATCH] backlight: adp8860: Mark expected switch fall-through

On Mon, 09 Jul 2018, Gustavo A. R. Silva wrote:

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/video/backlight/adp8860_bl.c | 1 +
> 1 file changed, 1 insertion(+)

Looks good to me, but Dan should still review.

https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc.pdf#page=86

Acked-by: Lee Jones <[email protected]>

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2018-07-10 06:44:28

by Hennerich, Michael

Subject: Re: [PATCH] backlight: adp8860: Mark expected switch fall-through

On 09.07.2018 23:51, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Acked-by: Michael Hennerich <[email protected]>

> ---
> drivers/video/backlight/adp8860_bl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 16119bd..f1dc41c 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client,
> switch (ADP8860_MANID(reg_val)) {
> case ADP8863_MANUFID:
> data->gdwn_dis = !!pdata->gdwn_dis;
> + /* fall through */
> case ADP8860_MANUFID:
> data->en_ambl_sens = !!pdata->en_ambl_sens;
> break;
>


--
Greetings,
Michael

--
Analog Devices GmbH Otl-Aicher Strasse 60-64 80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne

2018-07-10 09:02:22

by Daniel Thompson

Subject: Re: [PATCH] backlight: adp8860: Mark expected switch fall-through

On Mon, Jul 09, 2018 at 04:51:56PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Having checked the datasheets...

Reviewed-by: Daniel Thompson <[email protected]>

> ---
> drivers/video/backlight/adp8860_bl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 16119bd..f1dc41c 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client,
> switch (ADP8860_MANID(reg_val)) {
> case ADP8863_MANUFID:
> data->gdwn_dis = !!pdata->gdwn_dis;
> + /* fall through */
> case ADP8860_MANUFID:
> data->en_ambl_sens = !!pdata->en_ambl_sens;
> break;
> --
> 2.7.4
>

2018-07-13 07:36:35

by Lee Jones

Subject: Re: [PATCH] backlight: adp8860: Mark expected switch fall-through

On Mon, 09 Jul 2018, Gustavo A. R. Silva wrote:

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/video/backlight/adp8860_bl.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog