2018-07-10 13:06:57

by Ivan Khoronzhuk

Subject: [PATCH] net: ethernet: ti: cpts: break cycle once late ts is matched

The late ts queue can contain a bunch of skbs while hi rate testing,
no need to check all of them if timestamp is already matched.

Signed-off-by: Ivan Khoronzhuk <[email protected]>
---

Based on net-next/master

drivers/net/ethernet/ti/cpts.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index 6f63c8729afc..b4ea58dc8caf 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -114,7 +114,10 @@ static bool cpts_match_tx_ts(struct cpts *cpts, struct cpts_event *event)
dev_consume_skb_any(skb);
dev_dbg(cpts->dev, "match tx timestamp mtype %u seqid %04x\n",
mtype, seqid);
- } else if (time_after(jiffies, skb_cb->tmo)) {
+ break;
+ }
+
+ if (time_after(jiffies, skb_cb->tmo)) {
/* timeout any expired skbs over 1s */
dev_dbg(cpts->dev,
"expiring tx timestamp mtype %u seqid %04x\n",
--
2.17.1

2018-07-12 07:01:14

by David Miller

Subject: Re: [PATCH] net: ethernet: ti: cpts: break cycle once late ts is matched

From: Ivan Khoronzhuk <[email protected]>
Date: Tue, 10 Jul 2018 16:04:04 +0300

> The late ts queue can contain a bunch of skbs while hi rate testing,
> no need to check all of them if timestamp is already matched.
>
> Signed-off-by: Ivan Khoronzhuk <[email protected]>
> ---
>
> Based on net-next/master

Applied.