2018-07-14 01:29:13

by kernel test robot

Subject: [net-next:master 597/618] drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c:444:23: sparse: symbol 'mvpp2_cls_flow_get' was not declared. Should it be static?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: c921c2077b32081617789a645120148bc8b60c98
commit: f9358e12a0af53d107df09d4c0254425b6a10468 [597/618] net: mvpp2: split ingress traffic into multiple flows
reproduce:
# apt-get install sparse
git checkout f9358e12a0af53d107df09d4c0254425b6a10468
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c:444:23: sparse: symbol 'mvpp2_cls_flow_get' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

2018-07-14 01:29:22

by Fengguang Wu

Subject: [RFC PATCH net-next] net: mvpp2: mvpp2_cls_flow_get() can be static

Fixes: f9358e12a0af ("net: mvpp2: split ingress traffic into multiple flows")
Signed-off-by: kbuild test robot <[email protected]>
---
mvpp2_cls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
index dc7dfa9..723d0ba 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
@@ -557,7 +557,7 @@ static int mvpp2_flow_set_hek_fields(struct mvpp2_cls_flow_entry *fe,
return 0;
}

-struct mvpp2_cls_flow *mvpp2_cls_flow_get(int flow)
+static struct mvpp2_cls_flow *mvpp2_cls_flow_get(int flow)
{
if (flow >= MVPP2_N_FLOWS)
return NULL;

2018-07-14 03:23:13

by David Miller

Subject: Re: [RFC PATCH net-next] net: mvpp2: mvpp2_cls_flow_get() can be static

From: kbuild test robot <[email protected]>
Date: Sat, 14 Jul 2018 09:27:35 +0800

> Fixes: f9358e12a0af ("net: mvpp2: split ingress traffic into multiple flows")
> Signed-off-by: kbuild test robot <[email protected]>

Applied, thank you.