2018-07-16 12:41:22

by Gustavo A. R. Silva

Subject: [PATCH] drm/i915/selftests: Remove redundant code

err is assigned to -EIO, but this value is never actually
used and *err* is updated later on.

Remove such reduntant code.

Addresses-Coverity-ID: 1471816 ("Unused value")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/gpu/drm/i915/selftests/intel_guc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/selftests/intel_guc.c b/drivers/gpu/drm/i915/selftests/intel_guc.c
index 407c98f..c10e75c 100644
--- a/drivers/gpu/drm/i915/selftests/intel_guc.c
+++ b/drivers/gpu/drm/i915/selftests/intel_guc.c
@@ -206,7 +206,6 @@ static int igt_guc_clients(void *args)

if (!available_dbs(guc, guc->execbuf_client->priority)) {
pr_err("doorbell not available when it should\n");
- err = -EIO;
goto out_db;
}

--
2.7.4

2018-07-16 12:49:09

by Chris Wilson

Subject: Re: [PATCH] drm/i915/selftests: Remove redundant code

Quoting Gustavo A. R. Silva (2018-07-16 13:39:33)
> err is assigned to -EIO, but this value is never actually
> used and *err* is updated later on.
>
> Remove such reduntant code.

The mistake is that err is lost, possible masking the test failure.
Looks like the unwind needs to be refactored?
-Chris