Shawn:
Here's a couple of fixes for things I missed in the
[original-submission]. Sorry about the inconvenience.
Changes since [v1]:
- Reword commit message for patch 2/2
Thanks,
Andrey Smirnov
[v1] lkml.kernel.org/r/[email protected]
[original-submission] lkml.kernel.org/r/[email protected]
Andrey Smirnov (2):
ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config
ARM: dts: imx51-zii-scu3-esb: Fix RAVE SP watchdog compatible string
arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
--
2.17.1
It looks like I made a nasty typo in the original patch which resulted
in missing watchdog device. Fix it.
Cc: Fabio Estevam <[email protected]>
Cc: Nikita Yushchenko <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: [email protected]
Cc: Shawn Guo <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: Andrew Lunn <[email protected]>
Signed-off-by: Andrey Smirnov <[email protected]>
---
arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts
index 0bb42c00d72b..dffb761a1cc8 100644
--- a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts
+++ b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts
@@ -325,7 +325,7 @@
#size-cells = <1>;
watchdog {
- compatible = "zii,rave-sp-watchodg-legacy";
+ compatible = "zii,rave-sp-watchdog-legacy";
};
eeprom@a4 {
--
2.17.1
Instead of relying on default values, configure PAD_AUD3_BB_CK to be a
GPIO explicitly. While at, it change the pad configuration to enable
a 100K pull-down (the pin is used as IRQ_TYPE_LEVEL_HIGH).
Cc: Fabio Estevam <[email protected]>
Cc: Nikita Yushchenko <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: [email protected]
Cc: Shawn Guo <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: Andrew Lunn <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: Andrey Smirnov <[email protected]>
---
arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts
index 2941a92d40f1..0bb42c00d72b 100644
--- a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts
+++ b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts
@@ -221,6 +221,8 @@
interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
#interrupt-cells = <2>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_switch>;
ports {
#address-cells = <1>;
@@ -426,6 +428,12 @@
>;
};
+ pinctrl_switch: switchgrp {
+ fsl,pins = <
+ MX51_PAD_AUD3_BB_CK__GPIO4_20 0xc5
+ >;
+ };
+
pinctrl_uart1: uart1grp {
fsl,pins = <
MX51_PAD_UART1_RXD__UART1_RXD 0x1c5
--
2.17.1
On Fri, Jul 13, 2018 at 2:30 PM, Andrey Smirnov
<[email protected]> wrote:
> Instead of relying on default values, configure PAD_AUD3_BB_CK to be a
> GPIO explicitly. While at, it change the pad configuration to enable
> a 100K pull-down (the pin is used as IRQ_TYPE_LEVEL_HIGH).
>
> Cc: Fabio Estevam <[email protected]>
> Cc: Nikita Yushchenko <[email protected]>
> Cc: Lucas Stach <[email protected]>
> Cc: [email protected]
> Cc: Shawn Guo <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Mark Rutland <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: Andrew Lunn <[email protected]>
> Reviewed-by: Andrew Lunn <[email protected]>
> Signed-off-by: Andrey Smirnov <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
On Fri, Jul 13, 2018 at 2:30 PM, Andrey Smirnov
<[email protected]> wrote:
> It looks like I made a nasty typo in the original patch which resulted
> in missing watchdog device. Fix it.
>
> Cc: Fabio Estevam <[email protected]>
> Cc: Nikita Yushchenko <[email protected]>
> Cc: Lucas Stach <[email protected]>
> Cc: [email protected]
> Cc: Shawn Guo <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Mark Rutland <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: Andrew Lunn <[email protected]>
> Signed-off-by: Andrey Smirnov <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
On Fri, Jul 13, 2018 at 10:30:03AM -0700, Andrey Smirnov wrote:
> Andrey Smirnov (2):
> ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config
> ARM: dts: imx51-zii-scu3-esb: Fix RAVE SP watchdog compatible string
Applied both, thanks.