2018-07-14 01:59:38

by Anson Huang

Subject: [PATCH V2] ARM: dts: imx6sl-evk: add missing GPIO iomux setting

On i.MX6SL EVK board, the MX6SL_PAD_KEY_ROW5 pin is
used as lcd 3v3 regulator control pin, need to make
sure MX6SL_PAD_KEY_ROW5 is muxed as GPIO function
for controlling lcd 3v3 regulator.

Signed-off-by: Anson Huang <[email protected]>
---
change since V1:
using a separate pin group for lcd regulator instead of putting gpio pin in hog group.
arch/arm/boot/dts/imx6sl-evk.dts | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sl-evk.dts b/arch/arm/boot/dts/imx6sl-evk.dts
index 50bdc65..046cfab 100644
--- a/arch/arm/boot/dts/imx6sl-evk.dts
+++ b/arch/arm/boot/dts/imx6sl-evk.dts
@@ -77,6 +77,8 @@

reg_lcd_3v3: regulator-lcd-3v3 {
compatible = "regulator-fixed";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_reg_lcd_3v3>;
regulator-name = "lcd-3v3";
gpio = <&gpio4 3 GPIO_ACTIVE_HIGH>;
enable-active-high;
@@ -410,6 +412,12 @@
>;
};

+ pinctrl_reg_lcd_3v3: reglcd3v3grp {
+ fsl,pins = <
+ MX6SL_PAD_KEY_ROW5__GPIO4_IO03 0x17059
+ >;
+ };
+
pinctrl_uart1: uart1grp {
fsl,pins = <
MX6SL_PAD_UART1_RXD__UART1_RX_DATA 0x1b0b1
--
2.7.4

2018-07-14 16:11:25

by Fabio Estevam

Subject: Re: [PATCH V2] ARM: dts: imx6sl-evk: add missing GPIO iomux setting

Hi Anson,

On Fri, Jul 13, 2018 at 10:53 PM, Anson Huang <[email protected]> wrote:
> On i.MX6SL EVK board, the MX6SL_PAD_KEY_ROW5 pin is
> used as lcd 3v3 regulator control pin, need to make
> sure MX6SL_PAD_KEY_ROW5 is muxed as GPIO function
> for controlling lcd 3v3 regulator.
>
> Signed-off-by: Anson Huang <[email protected]>

Looks good now, thanks:

Reviewed-by; Fabio Estevam <[email protected]>

2018-07-17 06:49:24

by Shawn Guo

Subject: Re: [PATCH V2] ARM: dts: imx6sl-evk: add missing GPIO iomux setting

On Sat, Jul 14, 2018 at 09:53:58AM +0800, Anson Huang wrote:
> On i.MX6SL EVK board, the MX6SL_PAD_KEY_ROW5 pin is
> used as lcd 3v3 regulator control pin, need to make
> sure MX6SL_PAD_KEY_ROW5 is muxed as GPIO function
> for controlling lcd 3v3 regulator.
>
> Signed-off-by: Anson Huang <[email protected]>

Applied, thanks.