2018-07-17 14:00:39

by Yue Haibing

Subject: [PATCH net-next] tipc: remove unused tipc_link_is_active

tipc_link_is_active is no longer used and can be removed.

Signed-off-by: YueHaibing <[email protected]>
---
net/tipc/link.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/net/tipc/link.c b/net/tipc/link.c
index df763be..6987ffc 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
@@ -297,11 +297,6 @@ static bool link_is_bc_rcvlink(struct tipc_link *l)
return ((l->bc_rcvlink == l) && !link_is_bc_sndlink(l));
}

-int tipc_link_is_active(struct tipc_link *l)
-{
- return l->active;
-}
-
void tipc_link_set_active(struct tipc_link *l, bool active)
{
l->active = active;
--
2.7.0

2018-07-17 20:07:31

by Jon Maloy

Subject: RE: [PATCH net-next] tipc: remove unused tipc_link_is_active

Acked-by: Jon Maloy <[email protected]>

Thank you for fixing this.

> -----Original Message-----
> From: YueHaibing <[email protected]>
> Sent: Tuesday, 17 July, 2018 09:59
> To: [email protected]; Jon Maloy <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; [email protected]; YueHaibing
> <[email protected]>
> Subject: [PATCH net-next] tipc: remove unused tipc_link_is_active
>
> tipc_link_is_active is no longer used and can be removed.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> net/tipc/link.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/net/tipc/link.c b/net/tipc/link.c
> index df763be..6987ffc 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -297,11 +297,6 @@ static bool link_is_bc_rcvlink(struct tipc_link *l)
> return ((l->bc_rcvlink == l) && !link_is_bc_sndlink(l));
> }
>
> -int tipc_link_is_active(struct tipc_link *l)
> -{
> - return l->active;
> -}
> -
> void tipc_link_set_active(struct tipc_link *l, bool active)
> {
> l->active = active;
> --
> 2.7.0
>

2018-07-18 20:50:28

by David Miller

Subject: Re: [PATCH net-next] tipc: remove unused tipc_link_is_active

From: YueHaibing <[email protected]>
Date: Tue, 17 Jul 2018 21:58:46 +0800

> tipc_link_is_active is no longer used and can be removed.
>
> Signed-off-by: YueHaibing <[email protected]>

Applied.