This property was added in 2004 by
https://github.com/mpe/linux-fullhistory/commit/689fe5072fe9a0dec914bfa4fa60aed1e54563e6
and the only use of it, which was already inside `#if 0`, was removed a month
later by
https://github.com/mpe/linux-fullhistory/commit/1fbe5a6d90f6cd4ea610737ef488719d1a875de7
Fixes: https://github.com/linuxppc/linux/issues/125
Signed-off-by: Murilo Opsfelder Araujo <[email protected]>
---
arch/powerpc/kernel/prom_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 5425dd3d6a9f..c45fb463c9e5 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -2102,8 +2102,6 @@ static void __init prom_init_stdout(void)
stdout_node = call_prom("instance-to-package", 1, 1, prom.stdout);
if (stdout_node != PROM_ERROR) {
val = cpu_to_be32(stdout_node);
- prom_setprop(prom.chosen, "/chosen", "linux,stdout-package",
- &val, sizeof(val));
/* If it's a display, note it */
memset(type, 0, sizeof(type));
--
2.17.1
Hi Murilo,
Thanks for the patch.
Murilo Opsfelder Araujo <[email protected]> writes:
> This property was added in 2004 by
>
> https://github.com/mpe/linux-fullhistory/commit/689fe5072fe9a0dec914bfa4fa60aed1e54563e6
>
> and the only use of it, which was already inside `#if 0`, was removed a month
> later by
>
> https://github.com/mpe/linux-fullhistory/commit/1fbe5a6d90f6cd4ea610737ef488719d1a875de7
>
> Fixes: https://github.com/linuxppc/linux/issues/125
That is going to confuse some scripts that are expecting that to be a
"Fixes: <some commit>" tag :)
The proper tag to use there would be "Link:".
But, I'd prefer we didn't add github issue links to the history, as I'm
not sure they won't bit-rot eventually. Not because I'm a anti-Microsoft
conspiracy person but just because it's a repo I set up and manage and
there's no long term plan for it necessarily.
> ---
> arch/powerpc/kernel/prom_init.c | 2 --
> 1 file changed, 2 deletions(-)
Including the link here would be ideal, as it means it doesn't end up in
the commit history, but it does end up in the mail archive. So if we
ever really need to find it, it should be there.
cheers
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 5425dd3d6a9f..c45fb463c9e5 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -2102,8 +2102,6 @@ static void __init prom_init_stdout(void)
> stdout_node = call_prom("instance-to-package", 1, 1, prom.stdout);
> if (stdout_node != PROM_ERROR) {
> val = cpu_to_be32(stdout_node);
> - prom_setprop(prom.chosen, "/chosen", "linux,stdout-package",
> - &val, sizeof(val));
>
> /* If it's a display, note it */
> memset(type, 0, sizeof(type));
> --
> 2.17.1
On Wed, Jul 18, 2018 at 07:37:37PM +1000, Michael Ellerman wrote:
> Hi Murilo,
>
> Thanks for the patch.
>
> Murilo Opsfelder Araujo <[email protected]> writes:
> > This property was added in 2004 by
> >
> > https://github.com/mpe/linux-fullhistory/commit/689fe5072fe9a0dec914bfa4fa60aed1e54563e6
> >
> > and the only use of it, which was already inside `#if 0`, was removed a month
> > later by
> >
> > https://github.com/mpe/linux-fullhistory/commit/1fbe5a6d90f6cd4ea610737ef488719d1a875de7
> >
> > Fixes: https://github.com/linuxppc/linux/issues/125
>
> That is going to confuse some scripts that are expecting that to be a
> "Fixes: <some commit>" tag :)
>
> The proper tag to use there would be "Link:".
>
> But, I'd prefer we didn't add github issue links to the history, as I'm
> not sure they won't bit-rot eventually. Not because I'm a anti-Microsoft
> conspiracy person but just because it's a repo I set up and manage and
> there's no long term plan for it necessarily.
>
> > ---
> > arch/powerpc/kernel/prom_init.c | 2 --
> > 1 file changed, 2 deletions(-)
>
> Including the link here would be ideal, as it means it doesn't end up in
> the commit history, but it does end up in the mail archive. So if we
> ever really need to find it, it should be there.
>
> cheers
Hi, Michael.
Thanks for reviewing it. I've sent v2 with your suggestions:
https://lkml.kernel.org/r/[email protected]
Cheers
--
Murilo
Murilo Opsfelder Araujo <[email protected]> writes:
> On Wed, Jul 18, 2018 at 07:37:37PM +1000, Michael Ellerman wrote:
>> Murilo Opsfelder Araujo <[email protected]> writes:
>> > This property was added in 2004 by
>> >
>> > https://github.com/mpe/linux-fullhistory/commit/689fe5072fe9a0dec914bfa4fa60aed1e54563e6
>> >
>> > and the only use of it, which was already inside `#if 0`, was removed a month
>> > later by
>> >
>> > https://github.com/mpe/linux-fullhistory/commit/1fbe5a6d90f6cd4ea610737ef488719d1a875de7
>> >
>> > Fixes: https://github.com/linuxppc/linux/issues/125
>>
>> That is going to confuse some scripts that are expecting that to be a
>> "Fixes: <some commit>" tag :)
>>
>> The proper tag to use there would be "Link:".
>>
>> But, I'd prefer we didn't add github issue links to the history, as I'm
>> not sure they won't bit-rot eventually. Not because I'm a anti-Microsoft
>> conspiracy person but just because it's a repo I set up and manage and
>> there's no long term plan for it necessarily.
>>
>> > ---
>> > arch/powerpc/kernel/prom_init.c | 2 --
>> > 1 file changed, 2 deletions(-)
>>
>> Including the link here would be ideal, as it means it doesn't end up in
>> the commit history, but it does end up in the mail archive. So if we
>> ever really need to find it, it should be there.
>>
>> cheers
>
> Hi, Michael.
>
> Thanks for reviewing it. I've sent v2 with your suggestions:
>
> https://lkml.kernel.org/r/[email protected]
Thanks.
I had actually already applied the first version, but I didn't say that
in my email did I :}
So I've rebased and applied your v2, thanks.
cheers