2018-07-20 20:17:00

by Serge Semin

Subject: [PATCH] mips: mm: Discard ioremap_cacheable_cow() method

This macro substitution is the shortcut to map cacheable IO memory
with coherent and write-back attributes. Since it is entirely unused
by kernel, lets just remove it.

Signed-off-by: Serge Semin <[email protected]>
Suggested-by: Christoph Hellwig <[email protected]>
CC: Paul Burton <[email protected]>
Cc: James Hogan <[email protected]>
Cc: Ralf Baechle <[email protected]>
Cc: Sinan Kaya <[email protected]>
Cc: Huacai Chen <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
arch/mips/include/asm/io.h | 7 -------
1 file changed, 7 deletions(-)

diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h
index f613d1df66c0..cd170d920d55 100644
--- a/arch/mips/include/asm/io.h
+++ b/arch/mips/include/asm/io.h
@@ -300,13 +300,6 @@ static inline void __iomem * __ioremap_mode(phys_addr_t offset, unsigned long si
#define ioremap_wc(offset, size) \
__ioremap_mode((offset), (size), boot_cpu_data.writecombine)

-/*
- * This is a MIPS specific ioremap variant. ioremap_cacheable_cow
- * requests a cachable mapping with CWB attribute enabled.
- */
-#define ioremap_cacheable_cow(offset, size) \
- __ioremap_mode((offset), (size), _CACHE_CACHABLE_COW)
-
static inline void iounmap(const volatile void __iomem *addr)
{
if (plat_iounmap(addr))
--
2.12.0

2018-07-20 22:47:03

by Paul Burton

Subject: Re: [PATCH] mips: mm: Discard ioremap_cacheable_cow() method

Hi Serge,

On Fri, Jul 20, 2018 at 11:14:27PM +0300, Serge Semin wrote:
> This macro substitution is the shortcut to map cacheable IO memory
> with coherent and write-back attributes. Since it is entirely unused
> by kernel, lets just remove it.
>
> Signed-off-by: Serge Semin <[email protected]>
> Suggested-by: Christoph Hellwig <[email protected]>
> CC: Paul Burton <[email protected]>
> Cc: James Hogan <[email protected]>
> Cc: Ralf Baechle <[email protected]>
> Cc: Sinan Kaya <[email protected]>
> Cc: Huacai Chen <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> arch/mips/include/asm/io.h | 7 -------
> 1 file changed, 7 deletions(-)

Applied to mips-next for 4.19, thanks!

Paul