Hi,
When I try to (cross-)build arch/arc/ allmodconfig, I get a syntax error here:
./arch/arc/plat-eznps/mtm.c: In function 'mtm_enable_core':
../arch/arc/plat-eznps/mtm.c:113:30: error: storage size of 'dpc' isn't known
struct nps_host_reg_aux_dpc dpc;
^~~
There is no struct nps_host_reg_aux_dpc in the kernel tree.
Can you do something about this, please?
thanks,
--
~Randy
+CC some folks from Mellanox
On 07/18/2018 10:37 PM, Randy Dunlap wrote:
> Hi,
>
> When I try to (cross-)build arch/arc/ allmodconfig, I get a syntax error here:
>
> ./arch/arc/plat-eznps/mtm.c: In function 'mtm_enable_core':
> ../arch/arc/plat-eznps/mtm.c:113:30: error: storage size of 'dpc' isn't known
> struct nps_host_reg_aux_dpc dpc;
> ^~~
>
> There is no struct nps_host_reg_aux_dpc in the kernel tree.
>
> Can you do something about this, please?
Thx for the report Randy. I'm calling out Mellanox folks to see if they can
provide a fixup, else we will revert the corresponding change.
@Elad, upstream commit 3f9cd874dcc8705 "ARC: [plat-eznps] avoid toggling of DPC
register" added reference to struct nps_host_reg_aux_dpc but the definition is
missing. Can you please provide a fixup as I have no idea of that platform
specific struct.
@ Leon, reaching our to you, since it seems you removed Elad from MAINTAINERS
file, so I'm not sure if he is still at Mellanox.
The two folks I worked with on EZCHiip Linux port Noam Camus and Gilad have left
Mellanox.
If you or someone from Mellanox are interested in maintaining this platform,
please update the arch/arc/plat-eznps section of MAINTAINERS file.
Thx,
-Vineet
Hi Vineet,
Ofer Levi is now the maintainer of arch/arc/plat-eznps
Ofer,
Please take care of the issue below
Thanks
-----Original Message-----
From: Vineet Gupta [mailto:[email protected]]
Sent: Thursday, July 19, 2018 19:22
To: Randy Dunlap <[email protected]>; LKML <[email protected]>; Vineet Gupta <[email protected]>; [email protected]
Cc: Elad Kanfi <[email protected]>; Leon Romanovsky <[email protected]>
Subject: Re: arch/arc/ allmodconfig
+CC some folks from Mellanox
On 07/18/2018 10:37 PM, Randy Dunlap wrote:
> Hi,
>
> When I try to (cross-)build arch/arc/ allmodconfig, I get a syntax error here:
>
> ./arch/arc/plat-eznps/mtm.c: In function 'mtm_enable_core':
> ../arch/arc/plat-eznps/mtm.c:113:30: error: storage size of 'dpc' isn't known
> struct nps_host_reg_aux_dpc dpc;
> ^~~
>
> There is no struct nps_host_reg_aux_dpc in the kernel tree.
>
> Can you do something about this, please?
Thx for the report Randy. I'm calling out Mellanox folks to see if they can provide a fixup, else we will revert the corresponding change.
@Elad, upstream commit 3f9cd874dcc8705 "ARC: [plat-eznps] avoid toggling of DPC register" added reference to struct nps_host_reg_aux_dpc but the definition is missing. Can you please provide a fixup as I have no idea of that platform specific struct.
@ Leon, reaching our to you, since it seems you removed Elad from MAINTAINERS file, so I'm not sure if he is still at Mellanox.
The two folks I worked with on EZCHiip Linux port Noam Camus and Gilad have left Mellanox.
If you or someone from Mellanox are interested in maintaining this platform, please update the arch/arc/plat-eznps section of MAINTAINERS file.
Thx,
-Vineet
Hi Vineet, randy
Indeed this structure is missing, following is a patch based on linux-4.17.9.
Sorry about that.
Thanks
diff -uprN linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h
--- linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-22 16:16:09.000000000 +0300
+++ linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-23 11:18:12.179402620 +0300
@@ -143,6 +143,15 @@ struct nps_host_reg_gim_p_int_dst {
};
/* AUX registers definition */
+struct nps_host_reg_aux_dpc {
+ union {
+ struct {
+ u32 ien:1, men:1, hen:1, reserved:29;
+ };
+ u32 value;
+ };
+};
+
struct nps_host_reg_aux_udmc {
union {
struct {
> -----Original Message-----
> From: Meir Lichtinger
> Sent: Friday, July 20, 2018 10:19
> To: Vineet Gupta <[email protected]>; Randy Dunlap
> <[email protected]>; LKML <[email protected]>; linux-
> [email protected]; Ofer Levi(SW) <[email protected]>
> Cc: Leon Romanovsky <[email protected]>
> Subject: RE: arch/arc/ allmodconfig
>
> Hi Vineet,
> Ofer Levi is now the maintainer of arch/arc/plat-eznps
>
> Ofer,
> Please take care of the issue below
>
> Thanks
>
>
> -----Original Message-----
> From: Vineet Gupta [mailto:[email protected]]
> Sent: Thursday, July 19, 2018 19:22
> To: Randy Dunlap <[email protected]>; LKML <linux-
> [email protected]>; Vineet Gupta <[email protected]>;
> [email protected]
> Cc: Elad Kanfi <[email protected]>; Leon Romanovsky
> <[email protected]>
> Subject: Re: arch/arc/ allmodconfig
>
> +CC some folks from Mellanox
>
> On 07/18/2018 10:37 PM, Randy Dunlap wrote:
> > Hi,
> >
> > When I try to (cross-)build arch/arc/ allmodconfig, I get a syntax error here:
> >
> > ./arch/arc/plat-eznps/mtm.c: In function 'mtm_enable_core':
> > ../arch/arc/plat-eznps/mtm.c:113:30: error: storage size of 'dpc' isn't known
> > struct nps_host_reg_aux_dpc dpc;
> > ^~~
> >
> > There is no struct nps_host_reg_aux_dpc in the kernel tree.
> >
> > Can you do something about this, please?
>
> Thx for the report Randy. I'm calling out Mellanox folks to see if they can
> provide a fixup, else we will revert the corresponding change.
>
> @Elad, upstream commit 3f9cd874dcc8705 "ARC: [plat-eznps] avoid toggling
> of DPC register" added reference to struct nps_host_reg_aux_dpc but the
> definition is missing. Can you please provide a fixup as I have no idea of that
> platform specific struct.
>
> @ Leon, reaching our to you, since it seems you removed Elad from
> MAINTAINERS file, so I'm not sure if he is still at Mellanox.
> The two folks I worked with on EZCHiip Linux port Noam Camus and Gilad
> have left Mellanox.
> If you or someone from Mellanox are interested in maintaining this platform,
> please update the arch/arc/plat-eznps section of MAINTAINERS file.
>
>
> Thx,
> -Vineet
Hi Ofer,
On 07/23/2018 01:34 AM, Ofer Levi(SW) wrote:
> Hi Vineet, randy
>
> Indeed this structure is missing, following is a patch based on linux-4.17.9.
> Sorry about that.
>
> Thanks
>
>
> diff -uprN linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h
> --- linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-22 16:16:09.000000000 +0300
> +++ linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-23 11:18:12.179402620 +0300
> @@ -143,6 +143,15 @@ struct nps_host_reg_gim_p_int_dst {
> };
>
> /* AUX registers definition */
> +struct nps_host_reg_aux_dpc {
> + union {
> + struct {
> + u32 ien:1, men:1, hen:1, reserved:29;
> + };
> + u32 value;
> + };
> +};
> +
> struct nps_host_reg_aux_udmc {
> union {
> struct {
Thx for this change. Can you please send a proper patch with changelog, citing the
issue as Reported-by etc.
Also if Mellanox is interested in maintaining the NPS port going fwd, someone (you
?) should add their name to MAINTAINERS file under arch/arc/plat-eznps and send
that patch as well.
Thx,
-Vineet
>
>
>
>
>> -----Original Message-----
>> From: Meir Lichtinger
>> Sent: Friday, July 20, 2018 10:19
>> To: Vineet Gupta <[email protected]>; Randy Dunlap
>> <[email protected]>; LKML <[email protected]>; linux-
>> [email protected]; Ofer Levi(SW) <[email protected]>
>> Cc: Leon Romanovsky <[email protected]>
>> Subject: RE: arch/arc/ allmodconfig
>>
>> Hi Vineet,
>> Ofer Levi is now the maintainer of arch/arc/plat-eznps
>>
>> Ofer,
>> Please take care of the issue below
>>
>> Thanks
>>
>>
>> -----Original Message-----
>> From: Vineet Gupta [mailto:[email protected]]
>> Sent: Thursday, July 19, 2018 19:22
>> To: Randy Dunlap <[email protected]>; LKML <linux-
>> [email protected]>; Vineet Gupta <[email protected]>;
>> [email protected]
>> Cc: Elad Kanfi <[email protected]>; Leon Romanovsky
>> <[email protected]>
>> Subject: Re: arch/arc/ allmodconfig
>>
>> +CC some folks from Mellanox
>>
>> On 07/18/2018 10:37 PM, Randy Dunlap wrote:
>>> Hi,
>>>
>>> When I try to (cross-)build arch/arc/ allmodconfig, I get a syntax error here:
>>>
>>> ./arch/arc/plat-eznps/mtm.c: In function 'mtm_enable_core':
>>> ../arch/arc/plat-eznps/mtm.c:113:30: error: storage size of 'dpc' isn't known
>>> struct nps_host_reg_aux_dpc dpc;
>>> ^~~
>>>
>>> There is no struct nps_host_reg_aux_dpc in the kernel tree.
>>>
>>> Can you do something about this, please?
>> Thx for the report Randy. I'm calling out Mellanox folks to see if they can
>> provide a fixup, else we will revert the corresponding change.
>>
>> @Elad, upstream commit 3f9cd874dcc8705 "ARC: [plat-eznps] avoid toggling
>> of DPC register" added reference to struct nps_host_reg_aux_dpc but the
>> definition is missing. Can you please provide a fixup as I have no idea of that
>> platform specific struct.
>>
>> @ Leon, reaching our to you, since it seems you removed Elad from
>> MAINTAINERS file, so I'm not sure if he is still at Mellanox.
>> The two folks I worked with on EZCHiip Linux port Noam Camus and Gilad
>> have left Mellanox.
>> If you or someone from Mellanox are interested in maintaining this platform,
>> please update the arch/arc/plat-eznps section of MAINTAINERS file.
>>
>>
>> Thx,
>> -Vineet
On Mon, Jul 23, 2018 at 04:36:57PM +0000, Vineet Gupta wrote:
> Hi Ofer,
>
> On 07/23/2018 01:34 AM, Ofer Levi(SW) wrote:
> > Hi Vineet, randy
> >
> > Indeed this structure is missing, following is a patch based on linux-4.17.9.
> > Sorry about that.
> >
> > Thanks
> >
> >
> > diff -uprN linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h
> > --- linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-22 16:16:09.000000000 +0300
> > +++ linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-23 11:18:12.179402620 +0300
> > @@ -143,6 +143,15 @@ struct nps_host_reg_gim_p_int_dst {
> > };
> >
> > /* AUX registers definition */
> > +struct nps_host_reg_aux_dpc {
> > + union {
> > + struct {
> > + u32 ien:1, men:1, hen:1, reserved:29;
> > + };
> > + u32 value;
> > + };
> > +};
> > +
> > struct nps_host_reg_aux_udmc {
> > union {
> > struct {
>
> Thx for this change. Can you please send a proper patch with changelog, citing the
> issue as Reported-by etc.
> Also if Mellanox is interested in maintaining the NPS port going fwd, someone (you
> ?) should add their name to MAINTAINERS file under arch/arc/plat-eznps and send
> that patch as well.
Hi Vineet,
Thanks for your feedback, I'll work with Ofer to make it happen.
>
> Thx,
> -Vineet
>
>
> >
> >
> >
> >
> >> -----Original Message-----
> >> From: Meir Lichtinger
> >> Sent: Friday, July 20, 2018 10:19
> >> To: Vineet Gupta <[email protected]>; Randy Dunlap
> >> <[email protected]>; LKML <[email protected]>; linux-
> >> [email protected]; Ofer Levi(SW) <[email protected]>
> >> Cc: Leon Romanovsky <[email protected]>
> >> Subject: RE: arch/arc/ allmodconfig
> >>
> >> Hi Vineet,
> >> Ofer Levi is now the maintainer of arch/arc/plat-eznps
> >>
> >> Ofer,
> >> Please take care of the issue below
> >>
> >> Thanks
> >>
> >>
> >> -----Original Message-----
> >> From: Vineet Gupta [mailto:[email protected]]
> >> Sent: Thursday, July 19, 2018 19:22
> >> To: Randy Dunlap <[email protected]>; LKML <linux-
> >> [email protected]>; Vineet Gupta <[email protected]>;
> >> [email protected]
> >> Cc: Elad Kanfi <[email protected]>; Leon Romanovsky
> >> <[email protected]>
> >> Subject: Re: arch/arc/ allmodconfig
> >>
> >> +CC some folks from Mellanox
> >>
> >> On 07/18/2018 10:37 PM, Randy Dunlap wrote:
> >>> Hi,
> >>>
> >>> When I try to (cross-)build arch/arc/ allmodconfig, I get a syntax error here:
> >>>
> >>> ./arch/arc/plat-eznps/mtm.c: In function 'mtm_enable_core':
> >>> ../arch/arc/plat-eznps/mtm.c:113:30: error: storage size of 'dpc' isn't known
> >>> struct nps_host_reg_aux_dpc dpc;
> >>> ^~~
> >>>
> >>> There is no struct nps_host_reg_aux_dpc in the kernel tree.
> >>>
> >>> Can you do something about this, please?
> >> Thx for the report Randy. I'm calling out Mellanox folks to see if they can
> >> provide a fixup, else we will revert the corresponding change.
> >>
> >> @Elad, upstream commit 3f9cd874dcc8705 "ARC: [plat-eznps] avoid toggling
> >> of DPC register" added reference to struct nps_host_reg_aux_dpc but the
> >> definition is missing. Can you please provide a fixup as I have no idea of that
> >> platform specific struct.
> >>
> >> @ Leon, reaching our to you, since it seems you removed Elad from
> >> MAINTAINERS file, so I'm not sure if he is still at Mellanox.
> >> The two folks I worked with on EZCHiip Linux port Noam Camus and Gilad
> >> have left Mellanox.
> >> If you or someone from Mellanox are interested in maintaining this platform,
> >> please update the arch/arc/plat-eznps section of MAINTAINERS file.
> >>
> >>
> >> Thx,
> >> -Vineet
>
On 07/23/2018 01:34 AM, Ofer Levi(SW) wrote:
> Hi Vineet, randy
>
> Indeed this structure is missing, following is a patch based on linux-4.17.9.
> Sorry about that.
>
> Thanks
>
>
> diff -uprN linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h
> --- linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-22 16:16:09.000000000 +0300
> +++ linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-23 11:18:12.179402620 +0300
> @@ -143,6 +143,15 @@ struct nps_host_reg_gim_p_int_dst {
> };
>
> /* AUX registers definition */
> +struct nps_host_reg_aux_dpc {
> + union {
> + struct {
> + u32 ien:1, men:1, hen:1, reserved:29;
> + };
> + u32 value;
> + };
> +};
> +
> struct nps_host_reg_aux_udmc {
> union {
> struct {
>
Thanks, this fixes the build error.
I will not that outlook is not the best email client that you could use for
sending Linux patches. I don't know if you generated the patch with spaces
or tabs being used for indentation, but above, it contains all leading spaces
for indentation, which is Not Good.
--
~Randy
On 07/23/2018 10:02 AM, Leon Romanovsky wrote:
>>> diff -uprN linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h
>>> --- linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-22 16:16:09.000000000 +0300
>>> +++ linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-23 11:18:12.179402620 +0300
>>> @@ -143,6 +143,15 @@ struct nps_host_reg_gim_p_int_dst {
>>> };
>>>
>>> /* AUX registers definition */
>>> +struct nps_host_reg_aux_dpc {
>>> + union {
>>> + struct {
>>> + u32 ien:1, men:1, hen:1, reserved:29;
>>> + };
>>> + u32 value;
>>> + };
>>> +};
>>> +
>>> struct nps_host_reg_aux_udmc {
>>> union {
>>> struct {
>> Thx for this change. Can you please send a proper patch with changelog, citing the
>> issue as Reported-by etc.
>> Also if Mellanox is interested in maintaining the NPS port going fwd, someone (you
>> ?) should add their name to MAINTAINERS file under arch/arc/plat-eznps and send
>> that patch as well.
> Hi Vineet,
>
> Thanks for your feedback, I'll work with Ofer to make it happen.
Ping, folks can one of you please send a formal patch for this ?
-Vineet
On Fri, Jul 27, 2018 at 08:14:31PM +0000, Vineet Gupta wrote:
> On 07/23/2018 10:02 AM, Leon Romanovsky wrote:
> >>> diff -uprN linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h
> >>> --- linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-22 16:16:09.000000000 +0300
> >>> +++ linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h 2018-07-23 11:18:12.179402620 +0300
> >>> @@ -143,6 +143,15 @@ struct nps_host_reg_gim_p_int_dst {
> >>> };
> >>>
> >>> /* AUX registers definition */
> >>> +struct nps_host_reg_aux_dpc {
> >>> + union {
> >>> + struct {
> >>> + u32 ien:1, men:1, hen:1, reserved:29;
> >>> + };
> >>> + u32 value;
> >>> + };
> >>> +};
> >>> +
> >>> struct nps_host_reg_aux_udmc {
> >>> union {
> >>> struct {
> >> Thx for this change. Can you please send a proper patch with changelog, citing the
> >> issue as Reported-by etc.
> >> Also if Mellanox is interested in maintaining the NPS port going fwd, someone (you
> >> ?) should add their name to MAINTAINERS file under arch/arc/plat-eznps and send
> >> that patch as well.
> > Hi Vineet,
> >
> > Thanks for your feedback, I'll work with Ofer to make it happen.
>
> Ping, folks can one of you please send a formal patch for this ?
Vineet,
We sent the fix almost at the same day, but for some reason, the emails
from Ofer didn't arrive to ML.
I resent it,
https://www.mail-archive.com/[email protected]/msg03899.html
https://www.mail-archive.com/[email protected]/msg03864.html
And we will check with IT the reason why Ofer's email didn't work.
Thanks
>
> -Vineet