2018-07-25 12:23:25

by Quentin Schulz

Subject: [PATCH] MIPS: mscc: ocelot: fix length of memory address space for MIIM

The length of memory address space for MIIM0 is from 0x7107009c to
0x710700bf included which is 36 bytes long in decimal, or 0x24 bytes in
hexadecimal and not 0x36.

Fixes: 49b031690abe ("MIPS: mscc: Add switch to ocelot")

Signed-off-by: Quentin Schulz <[email protected]>
---
arch/mips/boot/dts/mscc/ocelot.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi
index 4f33dbc67348..7096915f26e0 100644
--- a/arch/mips/boot/dts/mscc/ocelot.dtsi
+++ b/arch/mips/boot/dts/mscc/ocelot.dtsi
@@ -184,7 +184,7 @@
#address-cells = <1>;
#size-cells = <0>;
compatible = "mscc,ocelot-miim";
- reg = <0x107009c 0x36>, <0x10700f0 0x8>;
+ reg = <0x107009c 0x24>, <0x10700f0 0x8>;
interrupts = <14>;
status = "disabled";

--
2.14.1

2018-07-25 12:34:28

by Alexandre Belloni

Subject: Re: [PATCH] MIPS: mscc: ocelot: fix length of memory address space for MIIM

On 25/07/2018 14:21:32+0200, Quentin Schulz wrote:
> The length of memory address space for MIIM0 is from 0x7107009c to
> 0x710700bf included which is 36 bytes long in decimal, or 0x24 bytes in
> hexadecimal and not 0x36.
>
> Fixes: 49b031690abe ("MIPS: mscc: Add switch to ocelot")
>
> Signed-off-by: Quentin Schulz <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>

> ---
> arch/mips/boot/dts/mscc/ocelot.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi
> index 4f33dbc67348..7096915f26e0 100644
> --- a/arch/mips/boot/dts/mscc/ocelot.dtsi
> +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi
> @@ -184,7 +184,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> compatible = "mscc,ocelot-miim";
> - reg = <0x107009c 0x36>, <0x10700f0 0x8>;
> + reg = <0x107009c 0x24>, <0x10700f0 0x8>;
> interrupts = <14>;
> status = "disabled";
>
> --
> 2.14.1
>

--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

2018-07-26 18:28:25

by Paul Burton

Subject: Re: [PATCH] MIPS: mscc: ocelot: fix length of memory address space for MIIM

Hi Quentin,

On Wed, Jul 25, 2018 at 02:21:32PM +0200, Quentin Schulz wrote:
> The length of memory address space for MIIM0 is from 0x7107009c to
> 0x710700bf included which is 36 bytes long in decimal, or 0x24 bytes in
> hexadecimal and not 0x36.
>
> Fixes: 49b031690abe ("MIPS: mscc: Add switch to ocelot")
>
> Signed-off-by: Quentin Schulz <[email protected]>
> ---
> arch/mips/boot/dts/mscc/ocelot.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks - applied to mips-next for 4.19.

Paul