2018-07-26 06:53:54

by agajjar

[permalink] [raw]
Subject: [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board

This board has SPI flash. add spi flash support in device tree.
Tested on pine64 LTS.

Signed-off-by: Akash Gajjar <[email protected]>
---
.../arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
index abe179d..9af07db 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
@@ -134,6 +134,18 @@
regulator-name = "vcc-wifi";
};

+&spi0 {
+ status = "okay";
+
+ flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "winbond,w25q128", "jedec,spi-nor";
+ reg = <0x0>;
+ spi-max-frequency = <40000000>;
+ };
+};
+
&uart0 {
pinctrl-names = "default";
pinctrl-0 = <&uart0_pins_a>;
--
2.7.4



2018-07-26 07:30:41

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board

1;5202;0c
On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> This board has SPI flash. add spi flash support in device tree.
> Tested on pine64 LTS.
>
> Signed-off-by: Akash Gajjar <[email protected]>

Queued for 4.20, thanks!

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


Attachments:
(No filename) (382.00 B)
signature.asc (849.00 B)
Download all attachments

2018-07-26 07:33:43

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board

On Thu, Jul 26, 2018 at 09:29:24AM +0200, Maxime Ripard wrote:
> 1;5202;0c
> On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> > This board has SPI flash. add spi flash support in device tree.
> > Tested on pine64 LTS.
> >
> > Signed-off-by: Akash Gajjar <[email protected]>
>
> Queued for 4.20, thanks!

No, sorry, I ended up droping that patch.

You mention that the Pine64 LTS has an SPI flash, yet you change the
sopine baseboard dts. Why is that?

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


Attachments:
(No filename) (615.00 B)
signature.asc (849.00 B)
Download all attachments

2018-07-26 08:01:35

by Emmanuel Vadot

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board

On Thu, 26 Jul 2018 09:31:38 +0200
Maxime Ripard <[email protected]> wrote:

> On Thu, Jul 26, 2018 at 09:29:24AM +0200, Maxime Ripard wrote:
> > 1;5202;0c
> > On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> > > This board has SPI flash. add spi flash support in device tree.
> > > Tested on pine64 LTS.
> > >
> > > Signed-off-by: Akash Gajjar <[email protected]>
> >
> > Queued for 4.20, thanks!
>
> No, sorry, I ended up droping that patch.
>
> You mention that the Pine64 LTS has an SPI flash, yet you change the
> sopine baseboard dts. Why is that?

There is still no dts for Pine64-LTS (Andre latest serie address that).
Note that the sopine.dtsi already have the SPI node, the patch is
present in sunxi/dt64-for-4.19

> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com


--
Emmanuel Vadot <[email protected]> <[email protected]>