2018-07-28 14:50:27

by Jeremy Cline

[permalink] [raw]
Subject: [PATCH v2] scripts: Add Python 3 support to tracing/draw_functrace.py

Use the print function. This maintains Python 2 support and should have
no functional change.

Signed-off-by: Jeremy Cline <[email protected]>
---

Changes from v1:
- Drop "from __future__ import print_function" as Python 2 is not long
for this world and in this case the statement and function behave
the same way.

scripts/tracing/draw_functrace.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/tracing/draw_functrace.py b/scripts/tracing/draw_functrace.py
index db40fa04cd51..9b6dd4f36335 100755
--- a/scripts/tracing/draw_functrace.py
+++ b/scripts/tracing/draw_functrace.py
@@ -123,7 +123,7 @@ def main():
tree = tree.getParent(caller)
tree = tree.calls(callee, calltime)

- print CallTree.ROOT
+ print(CallTree.ROOT)

if __name__ == "__main__":
main()
--
2.17.1



2018-07-29 02:13:08

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH v2] scripts: Add Python 3 support to tracing/draw_functrace.py

2018-07-28 23:48 GMT+09:00 Jeremy Cline <[email protected]>:
> Use the print function. This maintains Python 2 support and should have
> no functional change.
>
> Signed-off-by: Jeremy Cline <[email protected]>
> ---

Applied to linux-kbuild. Thanks!


> Changes from v1:
> - Drop "from __future__ import print_function" as Python 2 is not long
> for this world and in this case the statement and function behave
> the same way.
>
> scripts/tracing/draw_functrace.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/tracing/draw_functrace.py b/scripts/tracing/draw_functrace.py
> index db40fa04cd51..9b6dd4f36335 100755
> --- a/scripts/tracing/draw_functrace.py
> +++ b/scripts/tracing/draw_functrace.py
> @@ -123,7 +123,7 @@ def main():
> tree = tree.getParent(caller)
> tree = tree.calls(callee, calltime)
>
> - print CallTree.ROOT
> + print(CallTree.ROOT)
>
> if __name__ == "__main__":
> main()
> --
> 2.17.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Best Regards
Masahiro Yamada