2018-08-01 18:38:10

by Nick Desaulniers

[permalink] [raw]
Subject: get_maintainer.pl and change of email

It seems that get_maintainer.pl will make recommendations based on
commit history to a file, but over time, people change emails that
they commit from, then get_maintainer.pl recommends the possibly now
invalid email address.

I feel like we should have a look up table / file like MAINTAINERS
that tracks previous and new email addresses, which get_maintainer.pl
would parse, that way we have a record of movement between committer
email addresses allowing get_maintainer.pl to make more accurate
recommendations. Thoughts?
--
Thanks,
~Nick Desaulniers


2018-08-01 18:54:28

by Adam Borowski

[permalink] [raw]
Subject: Re: get_maintainer.pl and change of email

On Wed, Aug 01, 2018 at 11:36:23AM -0700, Nick Desaulniers wrote:
> It seems that get_maintainer.pl will make recommendations based on
> commit history to a file, but over time, people change emails that
> they commit from, then get_maintainer.pl recommends the possibly now
> invalid email address.
>
> I feel like we should have a look up table / file like MAINTAINERS
> that tracks previous and new email addresses, which get_maintainer.pl
> would parse, that way we have a record of movement between committer
> email addresses allowing get_maintainer.pl to make more accurate
> recommendations. Thoughts?

.mailmap

--
// If you believe in so-called "intellectual property", please immediately
// cease using counterfeit alphabets. Instead, contact the nearest temple
// of Amon, whose priests will provide you with scribal services for all
// your writing needs, for Reasonable And Non-Discriminatory prices.

2018-08-01 18:59:05

by Nick Desaulniers

[permalink] [raw]
Subject: Re: get_maintainer.pl and change of email

On Wed, Aug 1, 2018 at 11:53 AM Adam Borowski <[email protected]> wrote:
>
> On Wed, Aug 01, 2018 at 11:36:23AM -0700, Nick Desaulniers wrote:
> > It seems that get_maintainer.pl will make recommendations based on
> > commit history to a file, but over time, people change emails that
> > they commit from, then get_maintainer.pl recommends the possibly now
> > invalid email address.
> >
> > I feel like we should have a look up table / file like MAINTAINERS
> > that tracks previous and new email addresses, which get_maintainer.pl
> > would parse, that way we have a record of movement between committer
> > email addresses allowing get_maintainer.pl to make more accurate
> > recommendations. Thoughts?
>
> .mailmap

Neat, that's a start. It has a top level comment about being used by
git-shortlog, looks like get_maintainer.pl parses it, and it's a
default on option. Cool. Ok, looks like I just need to add someone
to the .mailmap file. Thanks!

--
Thanks,
~Nick Desaulniers