2018-08-02 00:32:09

by Gustavo A. R. Silva

Subject: [PATCH net-next] xen-netback: use true and false for boolean values

Return statements in functions returning bool should use true or false
instead of an integer value.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/net/xen-netback/netback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index a27daa2..3621e05 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1603,9 +1603,9 @@ static void xenvif_ctrl_action(struct xenvif *vif)
static bool xenvif_ctrl_work_todo(struct xenvif *vif)
{
if (likely(RING_HAS_UNCONSUMED_REQUESTS(&vif->ctrl)))
- return 1;
+ return true;

- return 0;
+ return false;
}

irqreturn_t xenvif_ctrl_irq_fn(int irq, void *data)
--
2.7.4

2018-08-02 07:56:57

by Wei Liu

Subject: Re: [PATCH net-next] xen-netback: use true and false for boolean values

On Wed, Aug 01, 2018 at 07:31:01PM -0500, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Acked-by: Wei Liu <[email protected]>

Thanks for the patch.

2018-08-02 21:44:39

by David Miller

Subject: Re: [PATCH net-next] xen-netback: use true and false for boolean values

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 1 Aug 2018 19:31:01 -0500

> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Applied.