LinuxLists.cc - [PATCH 1/1] selftest/net: fix protocol family to work for IPv4.

2018-08-02 10:43:20

Subject: [PATCH 1/1] selftest/net: fix protocol family to work for IPv4.

use actual protocol family passed by user rather than hardcoded
AF_INTE6 to cerate sockets.
current code is not working for IPv4.

Signed-off-by: Maninder Singh <[email protected]>
Signed-off-by: Vaneet Narang <[email protected]>
---
tools/testing/selftests/net/tcp_mmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c
index 77f7627..e8c5dff 100644
--- a/tools/testing/selftests/net/tcp_mmap.c
+++ b/tools/testing/selftests/net/tcp_mmap.c
@@ -402,7 +402,7 @@ int main(int argc, char *argv[])
exit(1);
}

- fd = socket(AF_INET6, SOCK_STREAM, 0);
+ fd = socket(cfg_family, SOCK_STREAM, 0);
if (fd == -1) {
perror("socket");
exit(1);
--
1.9.1

2018-08-02 13:04:36

by Eric Dumazet

[permalink] [raw]

Subject: Re: [PATCH 1/1] selftest/net: fix protocol family to work for IPv4.

On 08/02/2018 02:57 AM, Maninder Singh wrote:
> use actual protocol family passed by user rather than hardcoded
> AF_INTE6 to cerate sockets.
> current code is not working for IPv4.
>
> Signed-off-by: Maninder Singh <[email protected]>
> Signed-off-by: Vaneet Narang <[email protected]>
> ---
> tools/testing/selftests/net/tcp_mmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c
> index 77f7627..e8c5dff 100644
> --- a/tools/testing/selftests/net/tcp_mmap.c
> +++ b/tools/testing/selftests/net/tcp_mmap.c
> @@ -402,7 +402,7 @@ int main(int argc, char *argv[])
> exit(1);
> }
>
> - fd = socket(AF_INET6, SOCK_STREAM, 0);
> + fd = socket(cfg_family, SOCK_STREAM, 0);
> if (fd == -1) {
> perror("socket");
> exit(1);
>

Darn, someone spotted my hidden attempt to kill IPv4 ;)

Reviewed-by: Eric Dumazet <[email protected]>

2018-08-02 17:32:34

by David Miller

[permalink] [raw]

Subject: Re: [PATCH 1/1] selftest/net: fix protocol family to work for IPv4.

From: Maninder Singh <[email protected]>
Date: Thu, 2 Aug 2018 15:27:27 +0530

> use actual protocol family passed by user rather than hardcoded
> AF_INTE6 to cerate sockets.
> current code is not working for IPv4.
>
> Signed-off-by: Maninder Singh <[email protected]>
> Signed-off-by: Vaneet Narang <[email protected]>

Applied.

2018-08-02 17:36:21

by David Miller

[permalink] [raw]