Hi!
Getting prompt "The RDS Protocol" (RDS) is not too helpful, and it is
easily confused with Radio Data System (which we may want to support
in kernel, too).
I wonder if option should be named NET_RDS, instead?
And this sounds like a good idea:
(Plus, we normally have "module will be called foobar" and if unsure
say X. What happened to those?)
diff --git a/net/rds/Kconfig b/net/rds/Kconfig
index 41f7556..2738f14 100644
--- a/net/rds/Kconfig
+++ b/net/rds/Kconfig
@@ -1,6 +1,6 @@
config RDS
- tristate "The RDS Protocol"
+ tristate "The Reliable Datagram Sockets (RDS) Protocol"
depends on INET
---help---
The RDS (Reliable Datagram Sockets) protocol provides reliable,
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On (08/05/18 08:59), Pavel Machek wrote:
> Getting prompt "The RDS Protocol" (RDS) is not too helpful, and it is
> easily confused with Radio Data System (which we may want to support
> in kernel, too).
>
> I wonder if option should be named NET_RDS, instead?
RDS has been around for a while now (since 2.6). How will you
rename proposal manage backward compatibility? Why can't you call
your new option CONFIG_RADIO or similar instead?
Are we going to rename NFS* to NET_NFS* because someone decided
to reuse the NFS acronym?
> And this sounds like a good idea:
> - tristate "The RDS Protocol"
> + tristate "The Reliable Datagram Sockets (RDS) Protocol"
surn that sounds fine.
--Sowmini
On Sun 2018-08-05 06:19:45, Sowmini Varadhan wrote:
> On (08/05/18 08:59), Pavel Machek wrote:
> > Getting prompt "The RDS Protocol" (RDS) is not too helpful, and it is
> > easily confused with Radio Data System (which we may want to support
> > in kernel, too).
> >
> > I wonder if option should be named NET_RDS, instead?
>
> RDS has been around for a while now (since 2.6). How will you
> rename proposal manage backward compatibility? Why can't you call
> your new option CONFIG_RADIO or similar instead?
>
> Are we going to rename NFS* to NET_NFS* because someone decided
> to reuse the NFS acronym?
Was it?
Because this was first time kernel asked that question... when I was
testing -next. Is this related?
commit 533d1daea8d8a389b37207ad7b50c4e750969231
IB: Revert "remove redundant INFINIBAND kconfig dependencies"
> > And this sounds like a good idea:
> > - tristate "The RDS Protocol"
> > + tristate "The Reliable Datagram Sockets (RDS) Protocol"
>
> surn that sounds fine.
Can you apply the patch, or do you want me to send it to davem?
Signed-off-by: Pavel Machek <[email protected]>
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On (08/05/18 12:37), Pavel Machek wrote:
>
> Was it?
RDS was added in 2.6.30: see https://kernelnewbies.org/Linux_2_6_30
Recent RDS commits may have triggered the observation you note below
(you may have had it disabled by default until now)
> Because this was first time kernel asked that question... when I was
> testing -next. Is this related?
> Can you apply the patch, or do you want me to send it to davem?
> Signed-off-by: Pavel Machek <[email protected]>
please feel free to send the patch and add me as
Acked-by: Sowmini Varadhan <[email protected]>
--Sowmini
On 8/4/18 11:59 PM, Pavel Machek wrote:
> Hi!
>
> Getting prompt "The RDS Protocol" (RDS) is not too helpful, and it is
> easily confused with Radio Data System (which we may want to support
> in kernel, too).
>
Fair enough. Prompt change is fine Pavel.
> I wonder if option should be named NET_RDS, instead?
>
> And this sounds like a good idea:
>
> (Plus, we normally have "module will be called foobar" and if unsure
> say X. What happened to those?)
>
Module name is there for a while so please use different one if you
have a conflict with it.
> diff --git a/net/rds/Kconfig b/net/rds/Kconfig
> index 41f7556..2738f14 100644
> --- a/net/rds/Kconfig
> +++ b/net/rds/Kconfig
> @@ -1,6 +1,6 @@
>
> config RDS
> - tristate "The RDS Protocol"
> + tristate "The Reliable Datagram Sockets (RDS) Protocol"
> depends on INET
> ---help---
> The RDS (Reliable Datagram Sockets) protocol provides reliable,
>
Please git format this patch with your SOB and send it to netdev.
Feel free to add my ack with it.
Acked-by: Santosh Shilimkar <[email protected]>