2018-08-06 12:17:49

by Gustavo A. R. Silva

Subject: [PATCH] ASoC: wm8994: Fix missing break in switch

Add missing break statement in order to prevent the code from falling
through to the default case.

Cc: [email protected]
Addresses-Coverity-ID: 115050 ("Missing break in switch")
Reported-by: Valdis Kletnieks <[email protected]>
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
sound/soc/codecs/wm8994.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
index 62f8c5b..14f1b0c 100644
--- a/sound/soc/codecs/wm8994.c
+++ b/sound/soc/codecs/wm8994.c
@@ -2432,7 +2432,7 @@ static int wm8994_set_dai_sysclk(struct snd_soc_dai *dai,
snd_soc_component_update_bits(component, WM8994_POWER_MANAGEMENT_2,
WM8994_OPCLK_ENA, 0);
}
- /* fall through */
+ break;

default:
return -EINVAL;
--
2.7.4

2018-08-06 13:19:47

by Charles Keepax

Subject: Re: [PATCH] ASoC: wm8994: Fix missing break in switch

On Mon, Aug 06, 2018 at 07:14:51AM -0500, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through to the default case.
>
> Cc: [email protected]
> Addresses-Coverity-ID: 115050 ("Missing break in switch")
> Reported-by: Valdis Kletnieks <[email protected]>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles